Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tagged-concise-mid-tag and other tagged type definitions needed #74

Closed
nedmsmith opened this issue Mar 30, 2023 · 3 comments · Fixed by #89
Closed

tagged-concise-mid-tag and other tagged type definitions needed #74

nedmsmith opened this issue Mar 30, 2023 · 3 comments · Fixed by #89
Assignees

Comments

@nedmsmith
Copy link
Collaborator

There should be tagged tagged- definitions for the various types of tags that can be included in a corim.
for example a corim can contain these CBOR tagged structures:

$concise-tag-type-choice /= #6.505(bytes .cbor concise-swid-tag)
$concise-tag-type-choice /= #6.506(bytes .cbor concise-mid-tag)
$concise-tag-type-choice /= #6.508(bytes .cbor concise-bom-tag)

but we don't have a way to refer to each as a CBOR tagged statement, such as:

tagged-concise-swid-tag = #6.505(bytes .cbor concise-swid-tag)
tagged-concise-mid-tag = #6.506(bytes .cbor concise-mid-tag)
tagged-concise-bom-tag = #6.508(bytes .cbor concise-bom-tag)

The $concise-tag-type-choice definitions could become:

$concise-tag-type-choice /= tagged-concise-swid-tag
$concise-tag-type-choice /= tagged-concise-mid-tag
$concise-tag-type-choice /= tagged-concise-bom-tag
@thomas-fossati
Copy link
Collaborator

WFM

Do you plan to use the tagged payloads outside the CoRIM context?

@nedmsmith
Copy link
Collaborator Author

Yes. There is a use case for attestation results that copies Verifier input into attestation results and a use case that borrows from conditional-endorsed-triple-record. Otherwise, it is motivated generally by consistent naming convention.

@thomas-fossati
Copy link
Collaborator

ok, thanks for providing extra context.

@yogeshbdeshpande yogeshbdeshpande self-assigned this May 3, 2023
yogeshbdeshpande added a commit that referenced this issue May 9, 2023
Fixes #74

Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
yogeshbdeshpande added a commit that referenced this issue May 9, 2023
Fixes #74

Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants