-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group Membership & MEC Endorsment #168
Conversation
draft-ietf-rats-corim.md
Outdated
group-membership-triple-record = [ | ||
relative-top-layer-root: environment-map | ||
relative-sub-nodes: [ + environment-map ] | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this doesn't work when different revisions of CoMID have different definitions of what is in an environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this doesn't work when different revisions of CoMID have different definitions of what is in an environment
What doesn't work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hadn't realised that this is just a rename of domain-membership-triple-record to group-membership-triple-record. I am not convinced that rename makes the document better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tentatively renamed to "environment bundle"
draft-ietf-rats-corim.md
Outdated
multi-env-conditional-endorsement-triple-record = [ | ||
env: environment-map ; the environment to which the endorsed value | ||
; applies | ||
val: measurement-values-map ; the endorsed value | ||
cond: [ + stateful-environment-record ] ; all target environments along with | ||
; their expected state that need to match | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a version of this which adds multiple conditional endorsements (with the same condition for each). I think that is likely to be widely used, and for the cost of 1 additional byte is probably worthwhile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added multiple cardinality to val
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs work before we commit it. I have a similar proposal.
Yes, Me and Andrew today precisely worked on a better improved version of the same I would let Andrew come up with the First Draft and then we can review it together in the coming meeting! |
If the only difference is the array around |
fca9005
to
79841cf
Compare
I don't see the value in having multiple competing PRs. If there isn't consensus for how to solve a problem, then the issue is still in progress and not ready for a PR. Let's discard both PR #168 and #169 as these are competing PRs for an issue #136 that hasn't been closed. |
I have closed PR #169 - I don't think we have reached agreement on the goals. If we rush for a change before the deadline then we may make mistakes. |
79841cf
to
ef79a53
Compare
* rename "group membership" to "environment bundle" * allow multiple endorsed values in the MEC triple Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org> Co-authored-by: Thomas Fossati <thomas.fossati@linaro.org> Co-authored-by: Henk Birkholz <henk.birkholz@sit.fraunhofer.de>
b46ab1b
to
69a494b
Compare
multi-env-conditional-endorsement-triple-record = [ | ||
env: environment-map | ||
ends: [ + measurement-values-map ] | ||
cond: [ + stateful-environment-record ] | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multi-env-conditional-endorsement-triple-record = [ | |
env: environment-map | |
ends: [ + measurement-values-map ] | |
cond: [ + stateful-environment-record ] | |
] | |
multi-env-conditional-endorsement-triple-record = [ | |
cond: [ + stateful-environment-record ] | |
env: environment-map | |
ends: [ + measurement-values-map ] | |
] |
#177 now points to a wiki page illustrating the approach. |
fixes #136