Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to add multiplicity of Measurement Maps #265

Closed
wants to merge 1 commit into from

Conversation

yogeshbdeshpande
Copy link
Collaborator

@yogeshbdeshpande yogeshbdeshpande commented Sep 4, 2024

Modern day attesters have Multiple Measured Elements, within a Target Environment. This PR intends to allow multiple measured elements to be expressed using a single Reference Value Triple.

Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
@yogeshbdeshpande
Copy link
Collaborator Author

I am working on scanning the conditionality checks, so will make more commits to the PR!

@yogeshbdeshpande
Copy link
Collaborator Author

yogeshbdeshpande commented Sep 4, 2024

This is a slight modification to already closed PR #181 in which the new PR introduces backward compatibility with existing CDDL in Rev-01 to Rev-5 of the specification and also the Base TCG Specification

@yogeshbdeshpande
Copy link
Collaborator Author

@deeglaze If you feel al-right, feel free to make more commits on the branch!

@yogeshbdeshpande yogeshbdeshpande changed the title [WIP] Proposal to add multiplicity of Measurement Maps Proposal to add multiplicity of Measurement Maps Sep 4, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the meaning of this tag? I'm not sure why you need one when arrays and maps have different CBOR major type tags.

@deeglaze
Copy link
Collaborator

deeglaze commented Sep 4, 2024

@deeglaze If you feel al-right, feel free to make more commits on the branch!

I don't have push rights to this branch, so I have suggestions in my own commit on top in multiplicity...deeglaze:draft-ietf-rats-corim:multiplicity

Copy link
Collaborator

@nedmsmith nedmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A straightforward solution is added to the tcg-compatible branch https://github.com/ietf-rats-wg/draft-ietf-rats-corim/tree/tcg-compatible

It includes examples that are backward compatible with the TCG specs. It doesn't seem to need a CBOR tag.

@deeglaze
Copy link
Collaborator

Agreed it doesn't need the tag, but I do believe that conditional endorsements need to be updated to describe multiple mkeys at a time.

@nedmsmith
Copy link
Collaborator

Agreed it doesn't need the tag, but I do believe that conditional endorsements need to be updated to describe multiple mkeys at a time.

Conditional endorsements were an IETF invention. Hence, no backwards compatibility concerns. The conditional endorsement triple was already updated to add multiplicity. The conditional series triple has the needed multiplicity properties already (at least I haven't had any requests to change it from the people I work with).

@nedmsmith
Copy link
Collaborator

Contrast with #268
Maybe we should close this PR?

@yogeshbdeshpande
Copy link
Collaborator Author

The work proposed under this PR will be undertaken by PR: #268

Hence closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants