Revert endorsement and reference triple records to original #268
Conversation
created compatibility cddl and examples to test that demonstrate how to resolve incompatibilities between TCG and IETF corim schemas
The reference-triple-record and endorsed-triple-record are changed to allow multiple measurement-map measurements per environment.
Updated description of measurement keys and measurements sections to reflect multiplicity of same type measurements for a given environment.
Examples are updated to include array brackets around measurement-map in the reference and endorsement triple record.
nedmsmith
requested review from
deeglaze,
jdbeaney,
vinscarlata and
andrew-draper
nedmsmith
requested review from
henkbirkholz,
thomas-fossati and
yogeshbdeshpande
as code owners
|
The matching semantics wording needs to be updated to say that all measurement-maps have to match the ACS for the triple to apply. Edit: The text in the corroboration section is not clear about this. It indeed seems like it could be an OR semantics given
The text "where the reference-triple-record takes the place of a stateful-environment-record." is no longer the case since you haven't changed stateful-environment-record to have measurement-map multiplicity. |
Updated corroboration section 8.3 (sorry Thomas) and ECT internal representation section 8.1 to account for making Claims a multi-valued attribute of an ECT.
|
I modified Section 8.1 which defines the ECT structure, to reflect that claims-map always has multiplicity and to tweak naming to better reflect the idea that measurements can have "element IDs". I also modified the corroboration section (sorry Thomas) to better reflect the matching logic in terms of the internal representation. The before text was blending internal and external representation naming. |
Changed upload-artifact v2 to v4 to work around deprecated v2 tooling.
Co-authored-by: Dionna Amalie Glaze <dionnaglaze@google.com>
|
See issue #266 |
Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
|
We still need to work on other triples involving |
Corroboration text more clearly describes the process in terms of internal representations.
Changed wording from identical to match as identical seems too strong.
Updated ECT prose to better match CDDL naming anticipated in PR #284
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
Phase 1 Input transformation sections for reference and simple endorsement were fleshed out. Section in phase 3 describing corroboration was tightened ups. Phase 4 section on simple endorsement processing was fixed to use internal representation. Added notes to other sections in phase 4 that still require modification.
Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
Improved formatting, added parens around cross-references and added issues pointers for missing content.
|
@nedmsmith @thomas-fossati @deeglaze Thank you all for a great team effort, this PR is now in a pretty good shape, to be merged. We are happy and open to discuss the impact on Conditional Endorsed and Conditional Series triple. I have done some analysis which I will share in the github issue already created! @andrew-draper : Awaiting your analysis, as discussed earlier, however I understand, there are ways to improve conditional triples, orthogonal to this discussion hence we should merge this change, given all the collective hard work from CoRIM Team. @henkbirkholz : please review as well, your feedback is also super-important! |
This PR reverts
endorsement-triple-recordandreference-triple-recordto original CDDL by adding array brackets aroundmeasurement-mapto allow multiplicity of measurements for a given environment.The Measurements and Measurement Keys sections are updated to better describe measurement multiplicity and disambiguation of measurement values.