Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing text in --v2v3 output #455

Closed
ietf-svn-bot opened this issue Nov 20, 2019 · 3 comments
Closed

missing text in --v2v3 output #455

ietf-svn-bot opened this issue Nov 20, 2019 · 3 comments
Labels

Comments

@ietf-svn-bot
Copy link

owner:henrik@levkowetz.com resolution_fixed type_defect | by arusso@amsl.com


After v2->v3 conversion, the output file is missing text that was in the input file (inside a after a comment and before a ).

input:
https://www.rfc-editor.org/v3test/draft-ietf-iasa2-rfc6635bis-04-xml2.original.xml

output:
https://www.rfc-editor.org/v3test/draft-ietf-iasa2-rfc6635bis-04-xml2.after.xml

command used with v2.35.0:
xml2rfc --v2v3 --add-xinclude

The v3 output is missing the text between the comment and below.

input:

  <t>
  <!--
     For all decisions that affect the RSE individually (e.g., hiring and firing),
     the RSOC prepares recommendations for the IAB, but the final decision is
     the responsibility of the IAB.
  -->
     For all decisions that affect the RSE individually (e.g., hiring and
     firing), the RSOC prepares recommendations for the IAB, but approval
     of these recommendations is the responsibility of the IAB.
     For instance the RSOC would do the following:

     <list style="symbols">
       <t>perform annual reviews of the RSE and report the result of
       these reviews to the IAB.</t>
       <t> manage RSE candidate selection and advise the IAB on candidate
       appointment (in other words, select the RSE subject to IAB
       approval).</t>
     </list>
  </t>

output:

       <ul spacing="normal">
         <li>perform annual reviews of the RSE and report the result of
    these reviews to the IAB.</li>
         <li> manage RSE candidate selection and advise the IAB on candidate
    appointment (in other words, select the RSE subject to IAB
    approval).</li>
       </ul>

Issue migrated from trac:455 at 2022-02-08 07:03:34 +0000

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed status from new to closed

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed resolution from `` to fixed

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


Fixed in 60aef12:

Fixed the isempty() utility function to correctly return False for elements containing comments with trailing text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant