feat: added survey link #4345
Merged
feat: added survey link #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishkhuraishy
requested review from
ilgooz,
jeronimoalbi,
Pantani and
julienrbrt
as code owners
github-actions
bot
added
component:ci
* added api support to dynamically show announcements * fallbacks to a survey link * unit tests for the same
|
added api support and a fallback, attaching examples with and without a valid url |
julienrbrt
approved these changes
Sep 10, 2024
mergify bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
* feat: added survey link on exit * chore: added change log * feat(view): added announcement api support * added api support to dynamically show announcements * fallbacks to a survey link * unit tests for the same (cherry picked from commit 56c3730) # Conflicts: # ignite/cmd/model/chain_serve.go
julienrbrt
added a commit
that referenced
this pull request
Sep 10, 2024
* feat: added survey link (#4345) * feat: added survey link on exit * chore: added change log * feat(view): added announcement api support * added api support to dynamically show announcements * fallbacks to a survey link * unit tests for the same (cherry picked from commit 56c3730) # Conflicts: # ignite/cmd/model/chain_serve.go * updates * updates * updates * import --------- Co-authored-by: Ashish Khuraishy <ashishkhuraishy@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4211
The url is not going to be used anywhere else, so didn't make a separate variable for it - please let me know if the icon needs a change or the url to be a constant