From 9e52100e299693acc510199406daf65a179a180e Mon Sep 17 00:00:00 2001 From: Terry Kim Date: Wed, 8 Nov 2023 07:32:47 -0800 Subject: [PATCH] address comment --- .../execution/command/CreateTableClusterBySuiteBase.scala | 2 -- .../hive/execution/command/CreateTableClusterBySuite.scala | 5 +++++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/sql/core/src/test/scala/org/apache/spark/sql/execution/command/CreateTableClusterBySuiteBase.scala b/sql/core/src/test/scala/org/apache/spark/sql/execution/command/CreateTableClusterBySuiteBase.scala index 0efe769930352..cb56d11b665db 100644 --- a/sql/core/src/test/scala/org/apache/spark/sql/execution/command/CreateTableClusterBySuiteBase.scala +++ b/sql/core/src/test/scala/org/apache/spark/sql/execution/command/CreateTableClusterBySuiteBase.scala @@ -49,8 +49,6 @@ trait CreateTableClusterBySuiteBase extends QueryTest with DDLCommandTestUtils { } test("test clustering columns with comma") { - assume(!catalogVersion.contains("Hive")) // Hive catalog doesn't support column names with dots. - withNamespaceAndTable("ns", "table") { tbl => spark.sql(s"CREATE TABLE $tbl (`i,d` INT, data STRING) $defaultUsing " + "CLUSTER BY (`i,d`, data)") diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/command/CreateTableClusterBySuite.scala b/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/command/CreateTableClusterBySuite.scala index a3db451c6bffa..496cc13c49715 100644 --- a/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/command/CreateTableClusterBySuite.scala +++ b/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/command/CreateTableClusterBySuite.scala @@ -30,5 +30,10 @@ class CreateTableClusterBySuite extends v1.CreateTableClusterBySuiteBase with Co override protected val nestedClusteringColumns: Seq[String] = Seq("col2.col3") + // Hive catalog doesn't support column names with commas. + override def excluded: Seq[String] = Seq( + s"$command using Hive V1 catalog V1 command: test clustering columns with comma", + s"$command using Hive V1 catalog V2 command: test clustering columns with comma") + override def commandVersion: String = super[CreateTableClusterBySuiteBase].commandVersion }