From cf9313ced7e37dbf3f2974d6b29176002d88e016 Mon Sep 17 00:00:00 2001 From: stropho <3704482+stropho@users.noreply.github.com> Date: Tue, 6 Sep 2022 11:09:57 +0200 Subject: [PATCH] [meta] `CONTRIBUTING.md`: mention inactive PRs --- CHANGELOG.md | 2 ++ CONTRIBUTING.md | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 22a5c386b..b13d7170c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -40,6 +40,7 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange - [Docs] [`no-useless-path-segments`]: fix paths ([#2424], thanks [@s-h-a-d-o-w]) - [Tests] [`no-cycle`]: add passing test cases ([#2438], thanks [@georeith]) - [Refactor] [`no-extraneous-dependencies`] improve performance using cache ([#2374], thanks [@meowtec]) +- [meta] `CONTRIBUTING.md`: mention inactive PRs ([#2546], thanks [@stropho]) ## [2.26.0] - 2022-04-05 @@ -1013,6 +1014,7 @@ for info on changes for earlier releases. [`memo-parser`]: ./memo-parser/README.md +[#2546]: https://github.com/import-js/eslint-plugin-import/pull/2546 [#2541]: https://github.com/import-js/eslint-plugin-import/pull/2541 [#2531]: https://github.com/import-js/eslint-plugin-import/pull/2531 [#2511]: https://github.com/import-js/eslint-plugin-import/pull/2511 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 04e926505..0606b4a63 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -44,6 +44,10 @@ You can learn how from this _free_ series [How to Contribute to an Open Source P Here are some things to keep in mind when working on a PR: +**Trying to update an inactive Pull Request?** +If a PR is open, but unfortunately the author is, for any reason, not available to apply code review fixes or rebase the source branch, then please **do not open a new PR**. +Instead, paste a link to your own branch in the PR, and the maintainers can pull in your changes and update the existing PR in-place. + #### Tests A PR that is just failing test cases for an existing issue is very helpful, as this can take as much time (if not more) as it takes to implement a new feature or fix a bug.