Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pantab 4.0 checklist #219

Closed
9 of 10 tasks
WillAyd opened this issue Jan 10, 2024 · 2 comments
Closed
9 of 10 tasks

pantab 4.0 checklist #219

WillAyd opened this issue Jan 10, 2024 · 2 comments

Comments

@WillAyd
Copy link
Collaborator

WillAyd commented Jan 10, 2024

  • Improve error messages (don't just use RuntimeError)
  • Add tests for writing other libraries than pandas
  • Work upstream in pandas to improve dataframe interchange (or just use Arrow C Data)
    • date32 support
    • nullable integer support
    • nullable boolean support
    • proper serialization of arrow dtypes
  • proper benchmarks
  • communication around improvements

some nice to haves, but not blockers:

  • reuse hyper connection
@WillAyd
Copy link
Collaborator Author

WillAyd commented Jan 11, 2024

The current PR in #218 leverages the dataframe interchange protocol. However, after talking with Joris on the pandas team I am more convinced that using the new Arrow C Data protocol is a better bet. I have started that redevelopment which does simplify things, but I think am also hitting bugs with the PyCapsule exchange of information (this was just released in PyArrow 14.0)

@WillAyd
Copy link
Collaborator Author

WillAyd commented Jan 14, 2024

  • Add tests for writing other libraries than pandas

The latest design ended up using the Arrow C Data interchange, which hasn't been added upstream in pandas yet. So for now we require pyarrow and require pandas -> pyarrow -> pantab, but in the future we can just inspect a frame object for __arrow_array_stream__ without pyarrow and serialize from there.

See pandas-dev/pandas#56587 for pandas

@WillAyd WillAyd closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant