diff --git a/include/net/sock.h b/include/net/sock.h index 05a1bbdf58054d..6464da28e842a1 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -578,18 +578,22 @@ static inline bool sk_user_data_is_nocopy(const struct sock *sk) #define __sk_user_data(sk) ((*((void __rcu **)&(sk)->sk_user_data))) /** - * __rcu_dereference_sk_user_data_with_flags - return the pointer + * __rcu_dereference_sk_user_data_with_flags_check - return the pointer * only if argument flags all has been set in sk_user_data. Otherwise * return NULL * * @sk: socket * @flags: flag bits + * @condition: Condition under which non-RCU access may take place + * + * The caller must be holding the RCU read lock */ static inline void * -__rcu_dereference_sk_user_data_with_flags(const struct sock *sk, - uintptr_t flags) +__rcu_dereference_sk_user_data_with_flags_check(const struct sock *sk, + uintptr_t flags, bool condition) { - uintptr_t sk_user_data = (uintptr_t)rcu_dereference(__sk_user_data(sk)); + uintptr_t sk_user_data = + (uintptr_t)rcu_dereference_check(__sk_user_data(sk), condition); WARN_ON_ONCE(flags & SK_USER_DATA_PTRMASK); @@ -598,6 +602,12 @@ __rcu_dereference_sk_user_data_with_flags(const struct sock *sk, return NULL; } +static inline void * +__rcu_dereference_sk_user_data_with_flags(const struct sock *sk, uintptr_t flags) +{ + return __rcu_dereference_sk_user_data_with_flags_check(sk, flags, false); +} + #define rcu_dereference_sk_user_data(sk) \ __rcu_dereference_sk_user_data_with_flags(sk, 0) #define __rcu_assign_sk_user_data_with_flags(sk, ptr, flags) \ diff --git a/kernel/bpf/reuseport_array.c b/kernel/bpf/reuseport_array.c index 85fa9dbfa8bf88..856c360a591d48 100644 --- a/kernel/bpf/reuseport_array.c +++ b/kernel/bpf/reuseport_array.c @@ -24,7 +24,8 @@ void bpf_sk_reuseport_detach(struct sock *sk) struct sock __rcu **socks; write_lock_bh(&sk->sk_callback_lock); - socks = __rcu_dereference_sk_user_data_with_flags(sk, SK_USER_DATA_BPF); + socks = __rcu_dereference_sk_user_data_with_flags_check( + sk, SK_USER_DATA_BPF, lockdep_is_held(&sk->sk_callback_lock)); if (socks) { WRITE_ONCE(sk->sk_user_data, NULL); /*