Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong license detected by rollup-plugin-license #2391

Closed
Jagget opened this issue Apr 24, 2020 · 2 comments
Closed

Wrong license detected by rollup-plugin-license #2391

Jagget opened this issue Apr 24, 2020 · 2 comments
Labels

Comments

@Jagget
Copy link
Contributor

Jagget commented Apr 24, 2020

Stencil version:

 @stencil/core@1.11+

I'm submitting a:
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:

We are using rollup-plugin-license to compose NOTICE.txt file with 3rd party license info, and after Stencil compiler update we have this in the file:

Name: @stencil/core/internal/client
Version: 1.12.6
License: null
Private: true
Description: Stencil internal client platform to be imported by the Stencil Compiler. Breaking changes can and will happen at any time.

There's no license from @stencil/core, only from @stencil/core/internal/client

Expected behavior:
rollup-plugin-license should be able to detect full text from @stencil/core instead of @stencil/core/internal/client

Steps to reproduce:

const license = require('rollup-plugin-license');

export const config: Config = {
  plugins: [
    license({
      sourcemap: true,
      banner: {
        commentStyle: 'regular',
        content: `Copyright (c)`,
      },
      thirdParty: {
        includePrivate: true,
        output: {
          file: path.join(__dirname, 'NOTICE.txt'),
          encoding: 'utf-8',
        },
      },
    })
  ],
};

Other information:
All other dependencies compiled just fine:

  • @stencil/redux
  • lodash.debounce
  • axios
  • swipe-detect
@ionitron-bot ionitron-bot bot added the triage label Apr 24, 2020
@Jagget
Copy link
Contributor Author

Jagget commented Apr 24, 2020

Changing includePrivate: true to includePrivate: false will eliminate @stencil/core license from the file completely.

@Jagget
Copy link
Contributor Author

Jagget commented May 19, 2020

@Jagget Jagget closed this as completed May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant