Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Js ipfs issue 1145 #241

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

youngnicks
Copy link

Adds tests for cat errors when dealing with nested links. If No such file is still needed as a valid value, I can add it back.

Copy link
Contributor

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youngnicks nice! Have you run these with js-ipfs-api as well?

@youngnicks
Copy link
Author

I did not try it with js-ipfs-api, but I will after I get the final error messages sorted in 1145.

@youngnicks
Copy link
Author

I'm having some issues getting js-ipfs-api to use the new code. I installed my local versions of js-ipfs and interface-ipfs-core, but it seems to still be giving a different error. Do you guys have any tips on testing js-ipfs-api?

@youngnicks
Copy link
Author

Added go-ipfs version of error messages. From reading the docs, it sounds like it can connect to a go-ipfs node, which would give different error messages until the go-ipfs error messages are updated to match js-ipfs cat error messages.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants