This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
feat(breaking change): use stream on stats.bw #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
34 tasks
|
Needed for ipfs/js-ipfs#1198 /cc @diasdavid 😄 The new tests for this to pass are here: ipfs-inactive/interface-js-ipfs-core#211 |
|
hacdias
force-pushed
the
stream-statsbw
branch
from
1561a69
to
3a56d56
Compare
hacdias
force-pushed
the
stream-statsbw
branch
from
3a56d56
to
6ae5288
Compare
|
Note to self: Pull Stream version not working. Still don't know why. |
src/stats/bw-pull-stream.js
Outdated
| return p.end(err) | ||
| } | ||
|
|
||
| pull(toPull(stream), p) |
There was a problem hiding this comment.
this could be simply
pull(pull.map(transformChunk), p)
if I understand it correct
|
This is passing with the tests from ipfs-inactive/interface-js-ipfs-core#211 😄 I think it's ready /cc @diasdavid |
|
There you go :)
|
|
Thanks @diasdavid! Once the tests pass I'll ping you. |
|
@diasdavid the failing tests are unrelated to Stats (stats are passing). I think we can merge this and release a new version 😄 so I can continue ipfs/js-ipfs#1198 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stats.bwhas an option calledpollwhich allows the user to "tell" IPFS to send bandwidth stats each interval of time. We were collecting the response before calling the callback so that option would be useless.This way it sends a stream to the callback so the user can listen to
dataevent which contains the Object.Interface IPFS core update: ipfs-inactive/interface-js-ipfs-core#211