This repository has been archived by the owner on Aug 12, 2020. It is now read-only.
export is now a readable object stream #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function Exporter (hash, dagService, options) { | ||
| Readable.call(this, { objectMode: true }) | ||
|
|
||
| if (!(this instanceof Exporter)) { |
There was a problem hiding this comment.
You might be leaking memory in a weird way if this check doesn't come before the Readable.call(...) line.
|
|
||
| function fileExporter (node, name, dir, callback) { | ||
| this.fileExporter = (node, name, dir, callback) => { |
There was a problem hiding this comment.
Any reason why this function news to be exposed on the instantiated Object?
|
CR'ed :) |
| const ds = new DAGService(bs) | ||
| const testExport = exporter(hash, ds) | ||
| testExport.on('error', (err) => { | ||
| expect(err).to.exist |
There was a problem hiding this comment.
Can we check that it's the error we're expecting?
|
One comment, but otherwise 🐴 LGTM |
| @@ -78,5 +87,16 @@ module.exports = function (repo) { | |||
| done() | |||
| }, 1000) | |||
| }) | |||
|
|
|||
| it('expect a dag service error over stream', (done) => { | |||
There was a problem hiding this comment.
s/'expect a dag service error over stream'/'fails on non existent hash'
|
@nginnever squash the 'updates commit' and update the README, then we are all set :) |
nginnever
force-pushed
the
exporter/duplex
branch
from
ed6a280
to
984b42d
Compare
|
Awesome! :D |
|
Niiice |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @diasdavid @dignifiedquire could use a look at this :D