Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple "Error: Callback was already called" with js-ipfs fallback #50

Closed
lidel opened this issue Nov 25, 2018 · 1 comment
Closed

Multiple "Error: Callback was already called" with js-ipfs fallback #50

lidel opened this issue Nov 25, 2018 · 1 comment
Assignees
@fsdiogo
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@lidel
Copy link
Member

lidel commented Nov 25, 2018 •
edited
Loading

When js-ipfs fallback is used in Google Chrome v70 this happens in console
(as far I could tell, it does not seem to impact download):

2018-11-25--01-36-28

How to Replicate

References
@lidel lidel added the kind/bug A bug in existing code (including security flaws) label Nov 25, 2018
@fsdiogo fsdiogo mentioned this issue Nov 26, 2018
Merged
@ghost ghost assigned fsdiogo Nov 26, 2018
@ghost ghost added the status/in-progress In progress label Nov 26, 2018
@fsdiogo
Copy link
Contributor

fsdiogo commented Nov 26, 2018

Thanks for the report and for pointing out the solution @lidel 😄

I've created a PR with the fix.

fsdiogo added a commit that referenced this issue Nov 26, 2018
@fsdiogo
fix: webpack config (#51)
09dc416 
Fixes #50.
@ghost ghost removed the status/in-progress In progress label Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsdiogo fsdiogo

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lidel @fsdiogo