Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-enable test coverage #1195

Merged
merged 6 commits into from
Oct 24, 2023
Merged

fix: re-enable test coverage #1195

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
79b384a
fix: re-enable test coverage
achingbrain Feb 20, 2023
cbe463b
test: test on lts and current
achingbrain Jun 10, 2023
3c37832
chore: update c8
achingbrain Jun 15, 2023
ba3ef52
Merge branch 'master' into fix/re-enable-test-coverage
achingbrain Jul 26, 2023
9371e61
Merge branch 'master' into fix/re-enable-test-coverage
achingbrain Oct 24, 2023
70369dc
Apply suggestions from code review
achingbrain Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/cmds/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@
* @param {any} argv
*/
async handler (argv) {
// temporarily disable code coverage on node 18
if (argv.cov && process.version.startsWith('v18.')) {
console.warn(kleur.red('!!! Temporarily disabling code coverage\n')) // eslint-disable-line no-console
// temporarily disable code coverage on node targets running node 18
if (argv.cov && process.version.startsWith('v18.') && argv.target === 'node') {
console.warn(kleur.red('!!! Temporarily disabling code coverage - https://github.com/ipfs/aegir/issues/1206\n')) // eslint-disable-line no-console

Check warning on line 112 in src/cmds/test.js

View check run for this annotation

Codecov / codecov/patch

src/cmds/test.js#L112 

Added line #L112 was not covered by tests
delete argv.cov
}

Expand Down