Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: move to the new LTS accross all projects #350

Merged
merged 3 commits into from
Oct 31, 2018
Merged

docs: move to the new LTS accross all projects #350

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3822e25
docs: move to the new LTS accross all projects
daviddias Oct 31, 2018
1813b32
docs: apply review from vmx
daviddias Oct 31, 2018
2b2a044
docs: apply review
daviddias Oct 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions CONTRIBUTING_JS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,16 @@ Always run tests before pushing and PR'ing your code.

#### Supported Versions

IPFS projects support both the Current and Active LTS versions of Node.js. Please see [nodejs.org](https://nodejs.org/) for what these currently are.
The IPFS JavaScript projects work with the most recent LTS of Node.js and respective npm version that gets installed with Node.js. Please consult [nodejs.org](https://nodejs.org/) for LTS timeline. Today these are:

Browser code may be transpiled using Babel to take advantage of the latest JavaScript features.
```
» date -u +"%Y-%m-%dT%H:%M:%SZ"
2018-10-31T09:06:36Z
» node -v
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhpas doing a date -u +"%Y-%m-%dT%H:%M:%SZ" first, so that it is clear what "today" means?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

v10.13.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to have to update this with every LTS point release? The idea behind saying 'Look at the node website for what the current LTS is' was to reduce the amount of busywork we have to do.

Copy link

@jacobheun jacobheun Oct 31, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, we should not list the version here, it's easy to look up.

» npm -v
6.4.1
```

#### Linting & Code Style

Expand Down