Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

Bloom filter blockstore not checking cache on GetSize #77

Closed
aschmahmann opened this issue Jun 16, 2021 · 2 comments
Closed

Bloom filter blockstore not checking cache on GetSize #77

aschmahmann opened this issue Jun 16, 2021 · 2 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@aschmahmann
Copy link
Contributor

We have:

func (b *bloomcache) GetSize(k cid.Cid) (int, error) {
return b.blockstore.GetSize(k)
}

Unlike:

func (b *bloomcache) Get(k cid.Cid) (blocks.Block, error) {
if has, ok := b.hasCached(k); ok && !has {
return nil, ErrNotFound
}
return b.blockstore.Get(k)
}

This needs to be fixed in both v0 and v1 of the blockstore.

@aschmahmann aschmahmann added the need/triage Needs initial labeling and prioritization label Jun 16, 2021
@welcome
Copy link

welcome bot commented Jun 16, 2021

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@aschmahmann
Copy link
Contributor Author

resolved in #78 and #79

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

1 participant