This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Exchange don't add blocks on their own anymore #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Stebalien |
Stebalien
approved these changes
Jul 14, 2022
Jorropo
force-pushed
the
exchange-dont-add
branch
from
4b7a20c
to
070acfa
Compare
Jorropo
reviewed
Jul 27, 2022
offline_test.go
Outdated
| } | ||
|
|
||
| if _, err := store.Get(context.Background(), block.Cid()); err != nil { | ||
| t.Fatal(err) | ||
| err := ex.NotifyNewBlocks(context.Background(), block) |
There was a problem hiding this comment.
I'll push something that remove this test, it's literally testing that return nil returns nil, pointless.
Jorropo
force-pushed
the
exchange-dont-add
branch
from
070acfa
to
5732efa
Compare
The function body is just ```go return nil ``` And it's testing that this code returns nil. Pointless
Signed-off-by: Jorropo <jorropo.pgm@gmail.com>
Jorropo
force-pushed
the
exchange-dont-add
branch
from
5732efa
to
b006668
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows:
Note: require merging and bubbling ipfs/go-ipfs-exchange-interface#23