From 586f883d3f5ea0391cf3184024db9a60d9b4aa56 Mon Sep 17 00:00:00 2001 From: Hugo Dias Date: Fri, 22 Jan 2021 17:58:12 +0000 Subject: [PATCH] fix: fix datastore factory (#65) * fix: fix datastore factory The factory reference type can't extend the Datastore interface directly. We want the class instance to implement the interface and not the class (Object) reference. * fix: feedback * fix: export * fix: YAGNI --- src/index.js | 1 - src/types.ts | 5 ----- 2 files changed, 6 deletions(-) diff --git a/src/index.js b/src/index.js index 8e9cd62..f953ace 100644 --- a/src/index.js +++ b/src/index.js @@ -2,7 +2,6 @@ /** * @typedef {import('./types').Datastore} Datastore - * @typedef {import('./types').DatastoreFactory} DatastoreFactory * @typedef {import('./types').Batch} Batch * @typedef {import('./types').Options} Options * @typedef {import('./types').Query} Query diff --git a/src/types.ts b/src/types.ts index d1b73bd..267932b 100644 --- a/src/types.ts +++ b/src/types.ts @@ -18,11 +18,6 @@ export interface Batch { delete: (key: Key) => void commit: (options?: Options) => Promise } - -export interface DatastoreFactory extends Datastore { - new (): Datastore -} - export interface Datastore { open: () => Promise close: () => Promise