This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
feat: pubsub multibase and expanded dht #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds additional tests from #36 as well as some extras requested in the PR comments. Refs: ipfs/js-ipfs#3905
This extracts glue code that simplifies running interop against unreleased code of go-ipfs and js-ipfs packages from lerna monorepo. Makes it easier to demonstrate green CI and/or test end-to-end locally before submitting a PR.
the Rube Goldberg machine for testing HTTP RPC wire format changes end-to-end
This ensures we run interop with official binary that is provided to regular users. It also removes the need for `go` binary when running in CI in js-ipfs repo.
This was referenced Dec 7, 2021
Closed
lidel
force-pushed
the
feat/js-pubsub-and-dht
branch
from
ce65da2
to
d89ac81
Compare
this fixes js-ipfs ci matrix failing on macos – no need to check it there, as it also runs on win/linux
lidel
force-pushed
the
feat/js-pubsub-and-dht
branch
from
d89ac81
to
f0e3a6c
Compare
4 tasks
lidel
force-pushed
the
feat/js-pubsub-and-dht
branch
2 times, most recently
from
931c0d5
to
2639da4
Compare
lidel
force-pushed
the
feat/js-pubsub-and-dht
branch
from
2639da4
to
29d74be
Compare
|
I see we had js-ipfs-http-client release with pubsub earlier today, will switch this PR. |
lidel
force-pushed
the
feat/js-pubsub-and-dht
branch
from
2c07046
to
3db05ef
Compare
2 tasks
lidel
force-pushed
the
feat/js-pubsub-and-dht
branch
from
bcd49f3
to
559460a
Compare
|
Fixed small paper cuts, this branch now runs fine in ipfs/kubo#8613 (that PR is waiting for release of ipfs-interop) Ready for your final review @achingbrain |
achingbrain
approved these changes
Dec 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines #387 and #376
Needed for ipfs/js-ipfs#3922