Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading correct gateway port via API #591

Open
timthelion opened this issue Sep 20, 2018 · 6 comments
Open

Support reading correct gateway port via API #591

timthelion opened this issue Sep 20, 2018 · 6 comments
Labels
kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked

Comments

@timthelion
Copy link

See ipfs/kubo#5499

@timthelion
Copy link
Author

Here is what I see when I click on the plug in link.

GATEWAY http://127.0.0.1:8080
API http://127.0.0.1:5001
VERSION 0.4.17
PEERS 512

@lidel
Copy link
Member

lidel commented Sep 20, 2018

Hm.. what makes gateway port "correct" ? :)

Based on provided data you are running the go-ipfs node on port :8080 and it has 512 peers.
That is the default port Companion extension tries on first install, so far everything looks ok.

You mentioned also(?) running different gateway on :9001 – what is this about?
If you prefer to use gateway running on different port just update "Custom Gateway URL" in Preferences.

Hope this helps. (Let me know if I am missing something here)

@timthelion
Copy link
Author

Based on provided data you are running the go-ipfs node on port :8080 and it has 512 peers.
That is the default port Companion extension tries on first install, so far everything looks ok.

This isn't correct. I believe that the companion is connected successfully to the HTTP/API on the default port. But I never had the IPFS gateway configured for 8080.

What I would expect to happen, is that the companion would have a way of finding out the correct gateway via the API. I think that this will be a common problem, because 8080 is an extremely common port to use for HTTP servers.

@lidel lidel added the kind/enhancement A net-new feature or improvement to an existing feature label Sep 21, 2018
@lidel
Copy link
Member

lidel commented Sep 21, 2018

Ah, I think I got it now: so the bug-or-feature is that you are connected to API port of one node, but are using Gateway port of another one.

Automatic detection of gateway port by reading it from API was suggested in the past (#309) and we will need it for things like Brave integration, so it is on the roadmap.

Current plan is to deliver this feature as a part of #491. Stay tuned.

@lidel lidel added this to the New UI for Backend Control milestone Sep 21, 2018
@lidel lidel changed the title The correct gateway port is not detected Support reading correct gateway port via API Sep 21, 2018
@lidel lidel mentioned this issue Sep 21, 2018
11 tasks
@timthelion
Copy link
Author

Thanks. Closing as dup.

@lidel
Copy link
Member

lidel commented Sep 21, 2018

Let's keep it open as a part of milestone/14 :)

@lidel lidel reopened this Sep 21, 2018
@lidel lidel added the status/ready Ready to be worked label Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked
Projects
No open projects
Status: Needs Grooming
Development

No branches or pull requests

2 participants