Fallback to opening options page manually in brave #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but lets keep it open until #311 is merged. |
olizilla
changed the title
- Update options page fallback with path to dist - Dial down non-fatal error reporting. We already caught it.
olizilla
changed the title
|
@lidel all fixed up! We still don't get to see the browserAction icon in brave yet which is annoying but this PR gets the basics working in brave. |
lidel
approved these changes
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In brave the
runtime.openOptionsPage()call is failing, so the user can't update their prefs.See: brave/browser-laptop#7812
This PR adds a fallback to opening the options page as a browser tab if the
runtime.openOptionsPage()throws.Also, we add try/catch around calls the following currently unsupported apis
contextMenus.createcontextMenus.updateIn the meantime I'll follow up with brave to see what we need to do to make them available.
WIP on #312