Datastore integration #123
Conversation
README.md
Outdated
| │ │ │ │ │ │ │ │ | ||
| ├─────────────────┤ ├─────────────────┤ ├─────────────────┤ ├─────────────────┤ | ||
| │ FlatfsDatastore │ │LevelDBDatastore │ │LevelJSDatastore │ │LevelJSDatastore │ | ||
| └─────────────────┘ └─────────────────┘ └─────────────────┘ └─────────────────┘ |
There was a problem hiding this comment.
The drawing missing all the other things.
PS: monodraw is awesome, isn't it? :)
There was a problem hiding this comment.
it's a drawing of the datastores and how the are used, what you had before were not actual stores
|
|
||
| - The datastore folder holds the legacy version of datastore, still built in levelDB, there is a current endeavour of pushing it to fs completely. | ||
| - The blocks folder is the current version of datastore. | ||
| - The keys repo doesn't exist yet, as the private key is simply stored inside config |
There was a problem hiding this comment.
Oh, not important anymore? I think this plus my comment on @SidHarder PR -- #111 (comment) -- are valuable to keep around, we have explained this a countless number of times, we want to avoid spending all of that time again as much as possible.
There was a problem hiding this comment.
It's not correct anymore, that's why I removed it for now
There was a problem hiding this comment.
Only the last item is not valid anymore
There was a problem hiding this comment.
the first item is also not true, datastore is not legacy, it's being actively used and things added to it
There was a problem hiding this comment.
which makes the second incorrect as well
There was a problem hiding this comment.
making the last item the only one valid
README.md
Outdated
| var repo = new IPFSRepo('/Users/someone/.ipfs', { | ||
| stores: inMemoryBS | ||
| const Repo = require('ipfs-repo') | ||
| const repo = new Repo('/Users/awesome/.jsipfs') |
There was a problem hiding this comment.
Maybe use the universal /tmp folder instead?
README.md
Outdated
| stores: inMemoryBS | ||
| const Repo = require('ipfs-repo') | ||
| const repo = new Repo('/Users/awesome/.jsipfs') | ||
| repo.init(defaultConfig, (err) => { |
There was a problem hiding this comment.
Needs an example of what is the defaultConfig
README.md
Outdated
| } | ||
|
|
||
| console.log('repo is ready') | ||
| }) |
There was a problem hiding this comment.
A tree of the folder created would be useful here, just to give a visual representation of what is the repo.
package.json
Outdated
| "browser": { | ||
| "./src/lock.js": "./src/lock-browser.js", | ||
| "./src/default-config.js": "./src/default-config-browser.js" | ||
| }, |
There was a problem hiding this comment.
This was weird to me, there is the 'default-config' object that is passed on init, which apparently is what an IPFS config looks like, but then checking the 'default-config' files, it shows something entirely different.
Remember the lesson of: #111 (comment) :)
Lesson of the story: Naming things is hard, but it is even harder if you give the same name to everything
There was a problem hiding this comment.
fair point, any thoughts on better naming?
There was a problem hiding this comment.
renamed to default-options
package.json
Outdated
| @@ -31,27 +38,29 @@ | |||
| "node": ">=4.0.0" | |||
There was a problem hiding this comment.
While you are it, add npm engine as well
| @@ -31,27 +38,29 @@ | |||
| "node": ">=4.0.0" | |||
| }, | |||
| "devDependencies": { | |||
| "aegir": "^10.0.0", | |||
| "buffer-loader": "^0.0.1", | |||
| "aegir": "^11.0.0", | |||
| */ | ||
| close (callback) { | ||
| if (this.closed) { | ||
| return callback(new Error('repo is already closed')) | ||
| } |
There was a problem hiding this comment.
Different behaviour. open will return silently if it is already open, but close will return an error. Or return an error in both or silent in both.
There was a problem hiding this comment.
done, will always error now
src/index.js
Outdated
| } | ||
| callback(null, config.Identity.PrivKey) | ||
| }) | ||
| } |
There was a problem hiding this comment.
Why do we need this method here? Repo should not assume a specific format of the config file.
There was a problem hiding this comment.
This was in here before, I just migrated the functionality
Dragons inside ! 🐉 🐉 🐉
Integration with the new datastores, will have breaking api changes!
Will fix ipfs/js-ipfs#229 due to using https://github.com/dignifiedquire/lock-me for aquiring file system locks and exposing need methods to read and write the http api addr file.
ref ipfs/js-ipfs#787