No longer considers a non-existant repo an error. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling repo.exists() on a repo that doesn't exist would return an error rather than false, which would also mask whatever the underlying error really was.
| this.exists((err, exists) => { | ||
| if (err) { throw err } | ||
| if (exists) { throw new Error('Repo already exists') } | ||
| throw new Error('not implemented') |
There was a problem hiding this comment.
'not implemented' or 'repo not found'?
There was a problem hiding this comment.
There's no further implementation of repo.init yet, so 'not implemented' seemed fitting.
|
sweet, good catch! :) thank you noffle. Just made a tiny comment |
|
Ah, sorry, just saw your comments :) |
7 tasks
daviddias
added a commit
that referenced
this pull request
Mar 19, 2016
No longer considers a non-existant repo an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling repo.exists() on a repo that doesn't exist would return an error
rather than false, which would also mask whatever the underlying error
really was.