chore: make mimetype optional as it is in go #24
Conversation
ghost
assigned 
There was a problem hiding this comment.
This LGTM in that I can verify they both now have an optional MimeType.
Is this a breaking change?
Am I right in saying that this change will not affect anything to do with existing content (and would actually allow js-ipfs to deserialise content that has been created in go land without a MimeType?) but new content would get a different hash that it would have previously?
| @@ -20,5 +20,5 @@ module.exports = `message Data { | |||
| } | |||
|
|
|||
| message Metadata { | |||
| required string MimeType = 1; | |||
| optional string MimeType = 1; | |||
There was a problem hiding this comment.
This means that go-ipfs changed meanwhile. It would be great to have unixfs spec'ed out //cc @whyrusleeping @Stebalien
There was a problem hiding this comment.
for reference: ipfs/kubo#3458
tldr; DONT USE REQUIRED
|
@achingbrain can you answer @alanshaw's questions? If all is good, go ahead for the merge and release :) |
I don't think so, no - previous hashes would continue to work but anything newly hashed that didn't have a
Yes, exactly. |
|
@achingbrain gave you publish perms (seems that npm stopped having problems today) |
* feat: switch to async await * chore: update ipld formats * chore: update README * chore: standardise error codes
The mimetype is optional in go-ipfs-unixfs so this PR makes it optional in js too.