This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
wrapWithDirectory test fails #1328
Comments
vmx
added
kind/bug
A bug in existing code (including security flaws)
P0
Critical: Tackled by core team ASAP
status/blocked
Unable to be worked further until needs are met
labels
Apr 27, 2018
It seems that the test is correct as https://github.com/ipfs/js-ipfs-api/pull/750/files#diff-438d3282bfe7cdd71c3818dfce192cb6R167 also checks for two elements in the result. |
Test that broke ipfs/js-ipfs#master was added here: ipfs-inactive/interface-js-ipfs-core#251 and interface-ipfs-core version 0.60.1 was released without testing with js-ipfs first |
Agree that tests seems correct, but js-ipfs doesn't have the "wrap with directory" functionality yet |
There is a pending PR here though: #1290 |
@diasdavid this PR resolves this issue and makes CI green, could you please review and merge? #1329 |
daviddias
removed
the
status/blocked
Unable to be worked further until needs are met
label
Apr 30, 2018
Thank you for fixing this in a timely manner, @victorbjelkholm :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The test
interface-ipfs-core tests .files .add wrapWithDirectory
on master fails. To reproduce the issue, simply runnpx mocha --exit test/core/interface/files.js
from within the js-ipfs root directory.I make this a P0 as it prevent CI from passing.
The text was updated successfully, but these errors were encountered: