This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
chore: use same hashes as go #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
achingbrain
force-pushed
the
use-same-hashes-as-go
branch
from
48684c6
to
5cf2c8f
Compare
|
I think it's appropriate to add a set of interop tests for this so that our hashes don't diverge in the future! |
ipfs-inactive/js-ipfs-unixfs-engine#214 changes the algorithm used when adding files to be more consistent with the go implementation. This means some generated hashes will change. This PR updates those hashes in our test suite.
achingbrain
force-pushed
the
use-same-hashes-as-go
branch
from
5cf2c8f
to
4e0142b
Compare
alanshaw
approved these changes
Jun 18, 2018
This was referenced Jan 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipfs-inactive/js-ipfs-unixfs-engine#214 changes the algorithm used when adding files to be more
consistent with the go implementation. This means some generated hashes will change.
This PR updates those hashes in our test suite.
I've split these changes out from the MFS PR so we can look at these changes in isolation.
Requires the following to be merged:
ipfs/js-ipfs-unixfs#25
ipfs/js-ipfs-unixfs#24
ipfs-inactive/js-ipfs-unixfs-engine#213
ipfs-inactive/js-ipfs-unixfs-engine#214
fixes #1397