This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
updated cat core to return just file stream #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,7 +45,9 @@ module.exports = function files (self) { | |||
| callback('This dag node is a directory', null) | |||
| } else { | |||
| const exportStream = Exporter(hash, self._dagS) | |||
| callback(null, exportStream) | |||
| exportStream.on('data', (object) => { | |||
There was a problem hiding this comment.
s/on/once, so that the listener is cleared after
|
Missing
|
Merged
|
This needs PR merge for this to pass tests. |
|
|
||
| module.exports = function files (self) { | ||
| return { | ||
| add: (arr, callback) => { | ||
| add: promisify((arr, cb) => { |
There was a problem hiding this comment.
our pattern is to use callback as the most top level callback, so that it is easy distinguishable when we jump out the func
There was a problem hiding this comment.
that's just @diasdavid s pattern 😛
There was a problem hiding this comment.
haha to callback or cb, i'll switch back to callback here
11 tasks
|
Closing in favor of PR |
Closed
11 tasks
This was referenced Jan 20, 2022
This was referenced Mar 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came from conversation over the interface-core cat api talks PR.
This changes the core files cat command to return just the stream part of the unixfs-engine.exporter
This also updates the cat cli, http-api, and tests to respect the change.