Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Add basic example using ES7 async/await #865

Closed
wants to merge 1 commit into from

Conversation

enricomarino
Copy link
Contributor

No description provided.

@daviddias
Copy link
Member

I feel that this one should be an external example since we don't support async/await natively.

@enricomarino
Copy link
Contributor Author

enricomarino commented May 24, 2017

uh, right (async/await requires node >= 7.6, while ipfs requires node >= 4.5)

@enricomarino
Copy link
Contributor Author

(making the examples with promises) I noticed that init and start are not promisified in the lib, could we promisify them in the lib?

@daviddias
Copy link
Member

@enricomarino good catch. Yeah, wanna PR that in?

@enricomarino
Copy link
Contributor Author

sure!

@daviddias
Copy link
Member

Awesome! Closing this one PR then. Ping me when you make the PR to add promises to init and start, that should trickle an update of the previously added promises example. Thanks!

@daviddias daviddias closed this May 25, 2017
@enricomarino
Copy link
Contributor Author

enricomarino commented May 25, 2017

@diasdavid (already made when posted, so...) ping! :)

Promisify init #866
Promisify start #867

(I thought you were automatically notified,
but I imagine you've lots of notifications to check...)

@daviddias
Copy link
Member

Rad, thank you!

(I thought you were automatically notified, but I imagine you've lots of notifications to check...)

it is a bit like that these days, yes :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants