bug: nanoseconds

[SgtPooki]

Nanoseconds are calculated incorrectly. See ipfs/helia-verified-fetch#19 (comment) for more details. Basically,

Some proofs (copy and paste into dev console):

• nanoseconds are 1e9, or "One billionth of one second".
  • BigInt(1)/*<s>*/ * BigInt(1e9)/*<ns>*/ === (1000000000n)/*<ns>*/ /* 1,000,000,000/*<ns>*/
  • 1000000000/*<ns>*/ * 1e-9/*<ns-to-s>*/ === 1
• milliseconds are "1e6" or "One millionth of one second"
  • BigInt(1)/*<s>*/ * BigInt(1e6)/*<ms>*/ === 1000000n/*<ms>*/ /* === 1,000,000/*<ms>*/
  • 1000000/*<ms>*/ * 1e-6/*<ms-to-s>*/ === 1
• nanoseconds are 1e6 or "One millionth of one millisecond"
  • BigInt(1)/*<ms>*/ * BigInt(1e6)/*<ns>*/ === 1000000n/*<ns>*/ /* === 1,000,000/*<ms>*/
  • 1000000/*<ns>*/ * 1e-6/*<ns-to-ms>*/ === 1

js-ipns/src/index.ts

Line 171 in 16e0e10

const lifetimeNs = (BigInt(ms) * BigInt(100000)) + BigInt(ns ?? '0')

creates lifeTimeNs as:

function lifeTimeNs(ms, ns) {
    // BigInt(100000) === BigInt(1e5)
    return (BigInt(ms) * BigInt(100000)) + BigInt(ns ?? '0')
}
// should match BigInt(1)/*<ms>*/ * BigInt(1e6)/*<ns>*/ === 1000000n/*<ns>*/
lifeTimeNs(1) === BigInt(1e6) // false, 
// returns `100000n` instead of `1000000n`

references:

• https://en.wikipedia.org/wiki/Orders_of_magnitude_(time)#Less_than_one_second

[welcome]

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

• "Priority" labels will show how urgent this is for the team.
• "Status" labels will show if this is ready to be worked on, blocked, or in progress.
• "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.