config: update for new gateway options

License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ipfs · Jan 10, 2020 · 6509e39 · 6509e39
1 parent ab79a3c
commit 6509e39
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 33 deletions.
diff --git a/core/corehttp/gateway_handler.go b/core/corehttp/gateway_handler.go
@@ -31,34 +31,6 @@ const (
 	ipnsPathPrefix = "/ipns/"
 )
 
-type GatewaySpec struct {
-	// PathPrefixes list the set of path prefixes that should be handled by
-	// the gateway logic.
-	PathPrefixes []string
-
-	// UseSubdomains indicates whether or not this gateway uses subdomains
-	// for IPFS resources instead of paths. That is: http://CID.ipfs.GATEWAY/...
-	//
-	// If this flag is set, any /ipns/$id and/or /ipfs/$id paths in PathPrefixes
-	// will be permanently redirected to http://$id.[ipns|ipfs].$gateway/.
-	//
-	// We do not support using both paths and subdomains for a single domain
-	// for security reasons.
-	UseSubdomains bool
-}
-
-var DefaultGatewaySpec = GatewaySpec{
-	PathPrefixes:  []string{ipfsPathPrefix, ipnsPathPrefix, "/api/"},
-	UseSubdomains: false,
-}
-
-// TODO(steb): Configurable
-var KnownGateways = map[string]GatewaySpec{
-	"ipfs.io":         DefaultGatewaySpec,
-	"gateway.ipfs.io": DefaultGatewaySpec,
-	"localhost:8080":  DefaultGatewaySpec,
-}
-
 // gatewayHandler is a HTTP handler that serves IPFS objects (accessible by default at /ipfs/<path>)
 // (it serves requests like GET /ipfs/QmVRzPKPzNtSrEzBFm2UZfxmPAgnaLke4DMcerbsGGSaFe/link)
 type gatewayHandler struct {

diff --git a/core/corehttp/hostname.go b/core/corehttp/hostname.go
@@ -10,14 +10,51 @@ import (
 	core "github.com/ipfs/go-ipfs/core"
 	namesys "github.com/ipfs/go-ipfs/namesys"
 
+	config "github.com/ipfs/go-ipfs-config"
 	nsopts "github.com/ipfs/interface-go-ipfs-core/options/namesys"
 	isd "github.com/jbenet/go-is-domain"
 )
 
+var defaultGatewaySpec = config.GatewaySpec{
+	PathPrefixes:  []string{ipfsPathPrefix, ipnsPathPrefix, "/api/"},
+	UseSubdomains: false,
+}
+
+var defaultKnownGateways = map[string]config.GatewaySpec{
+	"ipfs.io":         defaultGatewaySpec,
+	"gateway.ipfs.io": defaultGatewaySpec,
+	"dweb.link": config.GatewaySpec{
+		PathPrefixes:  []string{ipfsPathPrefix, ipnsPathPrefix},
+		UseSubdomains: true,
+	},
+}
+
 // HostnameOption rewrites an incoming request based on the Host header.
 func HostnameOption() ServeOption {
 	return func(n *core.IpfsNode, _ net.Listener, mux *http.ServeMux) (*http.ServeMux, error) {
 		childMux := http.NewServeMux()
+
+		cfg, err := n.Repo.Config()
+		if err != nil {
+			return nil, err
+		}
+		knownGateways := make(
+			map[string]config.GatewaySpec,
+			len(defaultKnownGateways)+len(cfg.Gateway.PublicGateways),
+		)
+		for host, gw := range defaultKnownGateways {
+			knownGateways[host] = gw
+		}
+		for host, gw := range cfg.Gateway.PublicGateways {
+			if gw == nil {
+				// Allows the user to remove gateways but _also_
+				// allows us to continuously update the list.
+				delete(knownGateways, host)
+			} else {
+				knownGateways[host] = *gw
+			}
+		}
+
 		mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
 			ctx, cancel := context.WithCancel(n.Context())
 			defer cancel()
@@ -38,7 +75,7 @@ func HostnameOption() ServeOption {
 			// would "just work". Should we try this?
 
 			// Is this one of our "known gateways"?
-			if gw, ok := KnownGateways[r.Host]; ok {
+			if gw, ok := knownGateways[r.Host]; ok {
 				// This is a known gateway but we're not using
 				// the subdomain feature.
 
@@ -63,7 +100,7 @@ func HostnameOption() ServeOption {
 				// Looks like we're using subdomains.
 
 				// Again, is this a known gateway that supports subdomains?
-				if gw, ok := KnownGateways[host]; ok && gw.UseSubdomains {
+				if gw, ok := knownGateways[host]; ok && gw.UseSubdomains {
 
 					// Yes, serve the request (and rewrite the path to not use subdomains).
 					r.URL.Path = pathPrefix + r.URL.Path

diff --git a/go.mod b/go.mod
@@ -30,7 +30,7 @@ require (
 	github.com/ipfs/go-ipfs-blockstore v0.1.1
 	github.com/ipfs/go-ipfs-chunker v0.0.3
 	github.com/ipfs/go-ipfs-cmds v0.1.1
-	github.com/ipfs/go-ipfs-config v0.2.0
+	github.com/ipfs/go-ipfs-config v0.2.1-0.20200110091747-69d023fb5309
 	github.com/ipfs/go-ipfs-ds-help v0.0.1
 	github.com/ipfs/go-ipfs-exchange-interface v0.0.1
 	github.com/ipfs/go-ipfs-exchange-offline v0.0.1

diff --git a/go.sum b/go.sum
@@ -210,8 +210,8 @@ github.com/ipfs/go-ipfs-chunker v0.0.3 h1:UuXhKoxvxl/vGhie+WXFRZYCwpZjbKF2SzD1Tv
 github.com/ipfs/go-ipfs-chunker v0.0.3/go.mod h1:RkGJorerOQNTDPgmX7HtJ5YzVQqaIYdzI/hrCHty5Kc=
 github.com/ipfs/go-ipfs-cmds v0.1.1 h1:H9/BLf5rcsULHMj/x8gC0e5o+raYhqk1OQsfzbGMNM4=
 github.com/ipfs/go-ipfs-cmds v0.1.1/go.mod h1:k1zMXcOLtljA9iAnZHddbH69yVm5+weRL0snmMD/rK0=
-github.com/ipfs/go-ipfs-config v0.2.0 h1:c5UtyIRVdeSYRP2I1ZR167e9XJs5x8vepeo2w4I4+KU=
-github.com/ipfs/go-ipfs-config v0.2.0/go.mod h1:vEXbHHFPMCGCVhgv8oye4QF75kQ/gyZ3/tBdMMZFAps=
+github.com/ipfs/go-ipfs-config v0.2.1-0.20200110091747-69d023fb5309 h1:bMQ/X8L/X2ah7oiHMemjrxIL3iPdfsCepPmqkDCtQAQ=
+github.com/ipfs/go-ipfs-config v0.2.1-0.20200110091747-69d023fb5309/go.mod h1:vEXbHHFPMCGCVhgv8oye4QF75kQ/gyZ3/tBdMMZFAps=
 github.com/ipfs/go-ipfs-delay v0.0.0-20181109222059-70721b86a9a8/go.mod h1:8SP1YXK1M1kXuc4KJZINY3TQQ03J2rwBG9QfXmbRPrw=
 github.com/ipfs/go-ipfs-delay v0.0.1 h1:r/UXYyRcddO6thwOnhiznIAiSvxMECGgtv35Xs1IeRQ=
 github.com/ipfs/go-ipfs-delay v0.0.1/go.mod h1:8SP1YXK1M1kXuc4KJZINY3TQQ03J2rwBG9QfXmbRPrw=