Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let me show you my pokemans #2715

Closed
3 of 4 tasks
jbenet opened this issue May 17, 2016 · 1 comment
Closed
3 of 4 tasks

let me show you my pokemans #2715

jbenet opened this issue May 17, 2016 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@jbenet
Copy link
Member

jbenet commented May 17, 2016

mkdir foo
echo "bar" >foo/bar
f=$(ipfs add -r -q foo | tail -n1)
r=$(ipfs object new unixfs-dir);
r=$(ipfs object patch $r add-link bar /ipfs/$f/bar)
ipfs cat /ipfs/$r/bar
cat wat.png

TODO

  • check nil key in blockstore.Get and add test
  • check nil key in dagservice.Get and add test
  • object patch add-link should ParsePath and core.Resolve (not just parse key)
  • rm-link and other patch cmds same thing
@jbenet jbenet added the kind/bug A bug in existing code (including security flaws) label May 17, 2016
jbenet added a commit that referenced this issue May 17, 2016
Checks in:
- blockstore
- blockservice
- dagservice
- bitswap

Do not anger the pokemans #2715
jbenet added a commit that referenced this issue May 17, 2016
Checks in:
- blockstore
- blockservice
- dagservice
- bitswap

Do not anger the pokemans #2715

License: MIT
Signed-off-by: Juan Benet <juan@benet.ai>
@whyrusleeping
Copy link
Member

Nit: theres not a pokemon game cartridge in that GBA.

ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Apr 7, 2022
Checks in:
- blockstore
- blockservice
- dagservice
- bitswap

Do not anger the pokemans ipfs#2715

License: MIT
Signed-off-by: Juan Benet <juan@benet.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

2 participants