Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes repo existance check more sensitive. #2497

Merged
merged 1 commit into from
Apr 12, 2016

Conversation

hackergrrl
Copy link
Contributor

This makes the does-repo-exist check return true if 'config' exists OR
'datastore' exists, rather than a negated AND. This is helpful for js-ipfs or
other implementations which may not use a 'datastore' directory, since it
prevents false positives that could result in go-ipfs ovewriting another ipfs
implementation's repo.

@hackergrrl
Copy link
Contributor Author

(We really should have a canonical "is this an IPFS repo" check across impls in a spec. cc @diasdavid)

@hackergrrl hackergrrl added the need/review Needs a review label Mar 24, 2016
@whyrusleeping
Copy link
Member

I'm not sure i agree with this. If a config does not exist, we don't have a repo, regardless of whether or not we have a datastore directory (or a blocks directory, which seems to be missing from this outdated check)

@hackergrrl hackergrrl force-pushed the init_check branch 2 times, most recently from 3645f24 to b946509 Compare March 24, 2016 20:37
@hackergrrl
Copy link
Contributor Author

@whyrusleeping: ping. Are we good on this change? (Before I bother rebasing)

@whyrusleeping
Copy link
Member

Yeah, i'm okay with this change.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>
@hackergrrl
Copy link
Contributor Author

woo hoo -- ready for merge

@hackergrrl
Copy link
Contributor Author

Anything else we need here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants