Set correct content-type for ipfs get

[RichardLitt]

This is a version of #2004, with CR from @jbenet integrated in, and should close #1824

Related to ipfs-inactive/js-ipfs-http-client#263.

License: MIT
Signed-off-by: Richard Littauer richard.littauer@gmail.com

[RichardLitt]

Should have a negative test in here, too.

[Kubuxu]

Any idea why this test fails all over the board: https://travis-ci.org/ipfs/go-ipfs/jobs/134285028#L6773-L6779 ?

[RichardLitt]

I have no idea. @whyrusleeping?

[whyrusleeping]

the tests that fail are ipfs config? Thats weird... what content type is being returned through that command?

[RichardLitt]

When running on this branch:

curl -i -X POST "http://localhost:5001/api/v0/config?arg=API.HTTPHeaders"
HTTP/1.1 200 OK
Access-Control-Allow-Headers: X-Stream-Output, X-Chunked-Output, X-Content-Length
Access-Control-Expose-Headers: X-Stream-Output, X-Chunked-Output, X-Content-Length
Content-Type: application/json
Server: go-ipfs/0.4.2
Trailer: X-Stream-Error
Vary: Origin
Date: Mon, 13 Jun 2016 10:53:24 GMT
Transfer-Encoding: chunked

{"Key":"API.HTTPHeaders","Value":null}

[whyrusleeping]

@RichardLitt the reason this breaks the config command is because ipfs config show sets its output type as json (because, its output is json). Previously, made it so that any type we had an arbitrary byte stream being returned through the API, we called it text. When ipfs config show is rendered as text, its pretty printed with tabs and such for the user. Your change makes it so that hardcoding of text/plain changes back to json, and when json output is set, the output is not pretty printed (its meant to be machine readable, not so much human readable).

So here lies the issue. Should the output type of ipfs config show be text/plain when run from the command line? (even though the output is valid json)

[RichardLitt]

This isn't for ipfs config show, but for ipfs get, so I'm a bit confused.

[whyrusleeping]

@RichardLitt re-read my comment. You made a change that touches every command, that had some side effects. Take a look at the assumptions the old code made, and compare it to what your change does.

[RichardLitt]

Should the output type of ipfs config show be text/plain when run from the command line? (even though the output is valid json)

I would say no. It should be JSON. But I am not sure.

[whyrusleeping]

@RichardLitt Yeah, so thats the problem. The json formatter produces minified output, If a commands normal content type is JSON, then this PR will cause that command to produce the condensed minified output.

[RichardLitt]

Could we add an option to pretty-print, as desired?

[Kubuxu]

What is follow up for this?

[RichardLitt]

I am not attached to it. #2004 was not originally my pull request, and was closed without comment; I was trying to save what good there was in it. I don't feel familiar enough with the specific use case or the go-ipfs codebase right now to adequately change this. Feel free to close.