Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test with /ipns/ path #191

Closed
lidel opened this issue Mar 1, 2022 · 1 comment
Closed

Test with /ipns/ path #191

lidel opened this issue Mar 1, 2022 · 1 comment
Assignees
@SgtPooki
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up

Comments

@lidel
Copy link
Member

lidel commented Mar 1, 2022 •
edited
Loading

Sometimes people submit gateway that resolves /ipfs/ just fine, but fails with /ipns/en.wikipedia-on-ipfs.org

Implementation-wise, IPNS test could be done by trying to load Img from /ipns/en.wikipedia-on-ipfs.org/favicon.ico (we already have that for /ipfs, so just run the same test but for wikipedia favicon)
@lidel lidel added the need/triage Needs initial labeling and prioritization label Mar 1, 2022
@lidel lidel changed the title Test with `/ipns/ path Test with /ipns/ path Mar 1, 2022
@lidel lidel added help wanted Seeking public contribution on this issue good first issue Good issue for new contributors exp/novice Someone with a little familiarity can pick up P1 High: Likely tackled by core team if no one steps up effort/hours Estimated to take one or several hours and removed need/triage Needs initial labeling and prioritization labels Apr 11, 2022
@SgtPooki SgtPooki self-assigned this Jul 13, 2022
@whizzzkid whizzzkid mentioned this issue Oct 13, 2022
Merged
@whizzzkid whizzzkid assigned whizzzkid and SgtPooki and unassigned SgtPooki and whizzzkid Oct 14, 2022
@whizzzkid
Copy link
Contributor

Deployed in #313, fixed ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SgtPooki SgtPooki

Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
IPFS-GUI (PL EngRes)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lidel @SgtPooki @whizzzkid