Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): Follow Up to 310 - Adding more details to failed trustless test #312

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

whizzzkid
Copy link
Contributor

Follow up to #310.

In this PR:

  • Adding failed to tests to the debug messages.

@whizzzkid whizzzkid requested a review from a team as a code owner October 13, 2022 05:03
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: mind renaming "Trustless" to “Block/CAR” and link to end user docs at https://docs.ipfs.tech/reference/http/gateway/#trustless-verifiable-retrieval instead of gateway specs? 🙏

@whizzzkid
Copy link
Contributor Author

@lidel fixed

block:car

This may move the spacing in #313

@whizzzkid whizzzkid mentioned this pull request Oct 13, 2022
7 tasks
@SgtPooki
Copy link
Member

#trustless-verifiable-retrieval

I prefer "trustless" as that's how we're advertising it to customers, but block/car is direct and a link to the docs should help anyone understand if they want to know more

@whizzzkid whizzzkid merged commit f697993 into ipfs:master Oct 13, 2022
@whizzzkid whizzzkid deleted the fix/feat-pull-310 branch October 13, 2022 19:13
@lidel
Copy link
Member

lidel commented Oct 13, 2022

s/customers/users/ :))

yeah, this should be good enough until we clean up naming across docs and specs.

Digression:

I've heard some constructive feedback that "Trustless" is too vague, and confusing:
while you can verify blocks, you still "Trust" gateway with your privacy (gateway can track what CIDs you requested).

"Block/CAR" is very clear, but too technical. I wonder if "verifiable" is a better term overall?
I'd like us to unify this across docs and specs at some point, but naming is not my strong suit. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants