Allow parsing of single Null tokens from refmt #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For blocks that are simply "null": * dag-cbor: 0xf6 * dag-json: null
willscott
approved these changes
Aug 4, 2021
|
tests over @ https://github.com/ipld/codec-fixtures I'm planning on attempting an auto-gen sharness version of the fixtures to run them through go-ipfs, I could also do that for here as well but it would be doubling-up since I have go-ipld-prime running them over there already |
|
.. or we could git submodule, or wire it up into an Actions script to run on CI, or just do it manually |
|
as long as we monitor it somewhere and make sure it's running before releases, i'm in favor of whatever seems least complex but also won't just code-rot away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For blocks that are simply "null":
0xf6null