Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WalkTransforming traversal #376

Merged
merged 4 commits into from
Mar 7, 2022
Merged

Implement WalkTransforming traversal #376

merged 4 commits into from
Mar 7, 2022

Conversation

willscott
Copy link
Member

  • there's probably a better algorithm for the skip/don't skip subset of interests that are to be recursively traversed versus what's set up here.
  • there might be a way to combine the list and map recursion methods
  • should think about a reasonable set of test cases / fixtures

Copy link
Collaborator

@warpfork warpfork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me. (Not a detailed review; but it looks about right.)

I'm... probably not going to harp on test fixtures for this too much, for once (surprising though that might be). I think this function may be a golang-specific cul-de-sac a bit, and therefore I care a lot less.

When using `traversal.WalkTransforming`, progress is created without a cfg / linksystem. If links are present, that fails when it does not need to.
willscott added a commit to ipld/go-car that referenced this pull request Mar 6, 2022
@willscott
Copy link
Member Author

I considered if this needs to add the partial skip logic added in #358. I believe in the same way that it is not used for WalkLocal it isn't directly needed for WalkTransforming (or can be added later if it becomes needed)

@willscott willscott merged commit 4a1bd4f into master Mar 7, 2022
@willscott willscott deleted the walk_transforming branch March 7, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants