fix: staticcheck and govet fixes #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
force-pushed
the
rvagg/vet-and-check
branch
2 times, most recently
from
e173403
to
d3091e2
Compare
rvagg
commented
Apr 27, 2022
willscott
approved these changes
Apr 27, 2022
rvagg
force-pushed
the
rvagg/vet-and-check
branch
from
098a115
to
cd971f0
Compare
Co-authored-by: Will <will.scott@protocol.ai>
rvagg
force-pushed
the
rvagg/vet-and-check
branch
2 times, most recently
from
4f90160
to
10dfeca
Compare
rvagg
force-pushed
the
rvagg/vet-and-check
branch
from
10dfeca
to
f63238f
Compare
|
manually adding in go-check.yml workflow here because it now passes but there's some additional complications to the rest so more work to be done before we get web3bot in here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHHHH don't tell Eric about some of these changes
I think this and #405 might get us over the line for unified-ci