fix: staticcheck and govet fixes

.github/workflows/go-check.yml

@@ -0,0 +1,73 @@
+# File managed by web3-bot. DO NOT EDIT.
+# See https://github.com/protocol/.github/ for details.
+
+on: [push, pull_request]
+name: Go Checks
+
+jobs:
+  unit:
+    runs-on: ubuntu-latest
+    name: All
+    env:
+      RUNGOGENERATE: false
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: recursive
+      - uses: actions/setup-go@v2
+        with:
+          go-version: "1.18.x"
+      - name: Run repo-specific setup
+        uses: ./.github/actions/go-check-setup
+        if: hashFiles('./.github/actions/go-check-setup') != ''
+      - name: Read config
+        if: hashFiles('./.github/workflows/go-check-config.json') != ''
+        run: |
+          if jq -re .gogenerate ./.github/workflows/go-check-config.json; then
+            echo "RUNGOGENERATE=true" >> $GITHUB_ENV
+          fi
+      - name: Install staticcheck
+        run: go install honnef.co/go/tools/cmd/staticcheck@d7e217c1ff411395475b2971c0824e1e7cc1af98 # 2022.1 (v0.3.0)
+      - name: Check that go.mod is tidy
+        uses: protocol/multiple-go-modules@v1.2
+        with:
+          run: |
+            go mod tidy
+            if [[ -n $(git ls-files --other --exclude-standard --directory -- go.sum) ]]; then
+              echo "go.sum was added by go mod tidy"
+              exit 1
+            fi
+            git diff --exit-code -- go.sum go.mod
+      - name: gofmt
+        if: ${{ success() || failure() }} # run this step even if the previous one failed
+        run: |
+          out=$(gofmt -s -l .)
+          if [[ -n "$out" ]]; then
+            echo $out | awk '{print "::error file=" $0 ",line=0,col=0::File is not gofmt-ed."}'
+            exit 1
+          fi
+      - name: go vet
+        if: ${{ success() || failure() }} # run this step even if the previous one failed
+        uses: protocol/multiple-go-modules@v1.2
+        with:
+          run: go vet ./...
+      - name: staticcheck
+        if: ${{ success() || failure() }} # run this step even if the previous one failed
+        uses: protocol/multiple-go-modules@v1.2
+        with:
+          run: |
+            set -o pipefail
+            staticcheck ./... | sed -e 's@\(.*\)\.go@./\1.go@g'
+      - name: go generate
+        uses: protocol/multiple-go-modules@v1.2
+        if: (success() || failure()) && env.RUNGOGENERATE == 'true'
+        with:
+          run: |
+            git clean -fd # make sure there aren't untracked files / directories
+            go generate ./...
+            # check if go generate modified or added any files
+            if ! $(git add . && git diff-index HEAD --exit-code --quiet); then
+              echo "go generated caused changes to the repository:"
+              git status --short
+              exit 1
+            fi

codecHelpers_test.go

@@ -9,7 +9,7 @@ import (
 	"github.com/ipld/go-ipld-prime/schema"
 )
 
-func Example_Marshal() {
+func Example_marshal() {
 	type Foobar struct {
 		Foo string
 		Bar string
@@ -28,7 +28,7 @@ func Example_Marshal() {
 
 // TODO: Example_Unmarshal, which uses nil and infers a typesystem.  However, to match Example_Unmarshal_withSchema, that appears to need more features in bindnode.
 
-func Example_Unmarshal_withSchema() {
+func Example_unmarshal_withSchema() {
 	typesys := schema.MustTypeSystem(
 		schema.SpawnStruct("Foobar",
 			[]schema.StructField{

fluent/qp/qp.go

@@ -150,7 +150,7 @@ func (f floatParam) Assemble(na datamodel.NodeAssembler) {
 }
 
 func Float(f float64) Assemble {
-	return intParam(f).Assemble
+	return floatParam(f).Assemble
 }
 
 type stringParam string

linking/cid/cidLink.go

@@ -48,7 +48,7 @@ func (lp LinkPrototype) BuildLink(hashsum []byte) datamodel.Link {
 	p := lp.Prefix
 
 	length := p.MhLength
-	if p.MhType == multihash.ID {
+	if p.MhType == multihash.IDENTITY {
 		length = -1
 	}
 	if p.Version == 0 && (p.MhType != multihash.SHA2_256 ||

node/bindnode/infer.go

@@ -348,7 +348,7 @@ func inferGoType(typ schema.Type, status map[schema.TypeName]inferredStatus, lev
 
 // from IPLD Schema field names like "foo" to Go field names like "Foo".
 func fieldNameFromSchema(name string) string {
-	fieldName := strings.Title(name)
+	fieldName := strings.Title(name) //lint:ignore SA1019 cases.Title doesn't work for this
 	if !token.IsIdentifier(fieldName) {
 		panic(fmt.Sprintf("bindnode: inferred field name %q is not a valid Go identifier", fieldName))
 	}
@@ -418,10 +418,8 @@ func inferSchema(typ reflect.Type, level int) schema.Type {
 			return schemaTypeBytes
 		}
 
-		etyp := typ.Elem()
 		nullable := false
-		if etyp.Kind() == reflect.Ptr {
-			etyp = etyp.Elem()
+		if typ.Elem().Kind() == reflect.Ptr {
 			nullable = true
 		}
 		etypSchema := inferSchema(typ.Elem(), level+1)
@@ -433,7 +431,7 @@ func inferSchema(typ reflect.Type, level int) schema.Type {
 		defaultTypeSystem.Accumulate(typSchema)
 		return typSchema
 	}
-	panic(fmt.Sprintf("%s", typ.Kind()))
+	panic(typ.Kind().String())
 }
 
 // There are currently 27 reflect.Kind iota values,

node/bindnode/node.go

@@ -905,8 +905,6 @@ type _mapAssembler struct {
 	// TODO: more state checks
 
 	curKey _assembler
-
-	nextIndex int // only used by repr.go
 }
 
 func (w *_mapAssembler) AssembleKey() datamodel.NodeAssembler {
@@ -1000,8 +998,6 @@ type _unionAssembler struct {
 	// TODO: more state checks
 
 	curKey _assembler
-
-	nextIndex int // only used by repr.go
 }
 
 func (w *_unionAssembler) AssembleKey() datamodel.NodeAssembler {

node/tests/schemaLinks.go

@@ -24,7 +24,7 @@ import (
 var store = memstore.Store{}
 
 func encode(n datamodel.Node) (datamodel.Node, datamodel.Link) {
-	lp := cidlink.LinkPrototype{cid.Prefix{
+	lp := cidlink.LinkPrototype{Prefix: cid.Prefix{
 		Version:  1,
 		Codec:    0x0129,
 		MhType:   0x13,

node/tests/testutil.go

@@ -10,38 +10,9 @@ import (
 //  they'd probably be much less fragile and give better error messages that way.
 //  On the other hand, the functions for condensing two-arg returns wouldn't go away anyway.
 
-func plz(n datamodel.Node, e error) datamodel.Node {
-	if e != nil {
-		panic(e)
-	}
-	return n
-}
-
-func plzStr(n datamodel.Node, e error) string {
-	if e != nil {
-		panic(e)
-	}
-	if s, ok := n.AsString(); ok == nil {
-		return s
-	} else {
-		panic(ok)
-	}
-}
-
-func str(n datamodel.Node) string {
-	if s, ok := n.AsString(); ok == nil {
-		return s
-	} else {
-		panic(ok)
-	}
-}
-
-func erp(n datamodel.Node, e error) interface{} {
-	if e != nil {
-		return e
-	}
-	return n
-}
+// various benchmarks assign their final result here,
+// in order to defuse the possibility of their work being elided.
+var sink interface{} //lint:ignore U1000 used by benchmarks
 
 // purely to syntactically flip large inline closures so we can see the argument at the top rather than the bottom of the block.
 func withNode(n datamodel.Node, cb func(n datamodel.Node)) {

node/tests/util.go

@@ -9,10 +9,6 @@ import (
 	"github.com/ipld/go-ipld-prime/traversal/selector"
 )
 
-// various benchmarks assign their final result here,
-// in order to defuse the possibility of their work being elided.
-var sink interface{}
-
 func mustNodeFromJsonString(np datamodel.NodePrototype, str string) datamodel.Node {
 	nb := np.NewBuilder()
 	must.NotError(json.Decode(nb, strings.NewReader(str)))

printer/printer.go

@@ -107,13 +107,15 @@ func (cfg Config) oneline(typ schema.Type, isInKey bool) bool {
 	return isInKey // Future: this could become customizable, with some kind of Always|OnlyInKeys|Never option enum per type.
 }
 
+/* TODO: not implemented or used
 // useRepr decides if a value should be printed using its representation.
 // Sometimes configuring this to be true for structs or unions with stringy representations
 // will cause map printouts using them as keys to become drastically more readable
 // (if with some loss of informativeness, or at least loss of explicitness).
 func (cfg Config) useRepr(typ schema.Type, isInKey bool) bool {
 	return false
 }
+*/
 
 // useCmplxKeys decides if a map should print itself using a multi-line and extra-indented style for keys.
 func (cfg Config) useCmplxKeys(mapn datamodel.Node) bool {

schema/gen/go/adjunctCfg.go

@@ -65,7 +65,7 @@ func (cfg *AdjunctCfg) FieldSymbolUpper(f schema.StructField) string {
 	if x, ok := cfg.fieldSymbolUpperOverrides[FieldTuple{f.Type().Name(), f.Name()}]; ok {
 		return x
 	}
-	return strings.Title(f.Name())
+	return strings.Title(f.Name()) //lint:ignore SA1019 cases.Title doesn't work for this
 }
 
 // Comments returns a bool for whether comments should be included in gen output or not.
@@ -171,7 +171,7 @@ func sizeOfSchemaType(t schema.Type) uintptr {
 // and validated more aggressively up front when adjcfg is loaded.
 func (cfg *AdjunctCfg) UnionMemlayout(t schema.Type) string {
 	if t.TypeKind() != schema.TypeKind_Union {
-		panic(fmt.Errorf("%s is not a union!", t.Name()))
+		panic(fmt.Errorf("%s is not a union", t.Name()))
 	}
 	v, ok := cfg.CfgUnionMemlayout[t.Name()]
 	if !ok {

schema/gen/go/genBoolReprBool.go

@@ -77,7 +77,7 @@ func (g boolReprBoolReprGenerator) EmitNodePrototypeType(w io.Writer) {
 	`, w, g.AdjCfg, g)
 }
 func (g boolReprBoolReprGenerator) GetNodeBuilderGenerator() NodeBuilderGenerator {
-	return boolReprBoolReprBuilderGenerator{g.AdjCfg, g.Type}
+	return boolReprBoolReprBuilderGenerator(g)
 }
 
 type boolReprBoolReprBuilderGenerator struct {

schema/gen/go/genBytesReprBytes.go

@@ -77,7 +77,7 @@ func (g bytesReprBytesReprGenerator) EmitNodePrototypeType(w io.Writer) {
 	`, w, g.AdjCfg, g)
 }
 func (g bytesReprBytesReprGenerator) GetNodeBuilderGenerator() NodeBuilderGenerator {
-	return bytesReprBytesReprBuilderGenerator{g.AdjCfg, g.Type}
+	return bytesReprBytesReprBuilderGenerator(g)
 }
 
 type bytesReprBytesReprBuilderGenerator struct {

schema/gen/go/genFloatReprFloat.go

@@ -77,7 +77,7 @@ func (g float64ReprFloatReprGenerator) EmitNodePrototypeType(w io.Writer) {
 	`, w, g.AdjCfg, g)
 }
 func (g float64ReprFloatReprGenerator) GetNodeBuilderGenerator() NodeBuilderGenerator {
-	return float64ReprFloatReprBuilderGenerator{g.AdjCfg, g.Type}
+	return float64ReprFloatReprBuilderGenerator(g)
 }
 
 type float64ReprFloatReprBuilderGenerator struct {

schema/gen/go/genIntReprInt.go

@@ -77,7 +77,7 @@ func (g intReprIntReprGenerator) EmitNodePrototypeType(w io.Writer) {
 	`, w, g.AdjCfg, g)
 }
 func (g intReprIntReprGenerator) GetNodeBuilderGenerator() NodeBuilderGenerator {
-	return intReprIntReprBuilderGenerator{g.AdjCfg, g.Type}
+	return intReprIntReprBuilderGenerator(g)
 }
 
 type intReprIntReprBuilderGenerator struct {

schema/gen/go/genLinkReprLink.go

@@ -77,7 +77,7 @@ func (g linkReprLinkReprGenerator) EmitNodePrototypeType(w io.Writer) {
 	`, w, g.AdjCfg, g)
 }
 func (g linkReprLinkReprGenerator) GetNodeBuilderGenerator() NodeBuilderGenerator {
-	return linkReprLinkReprBuilderGenerator{g.AdjCfg, g.Type}
+	return linkReprLinkReprBuilderGenerator(g)
 }
 
 type linkReprLinkReprBuilderGenerator struct {

schema/gen/go/genStringReprString.go

@@ -77,7 +77,7 @@ func (g stringReprStringReprGenerator) EmitNodePrototypeType(w io.Writer) {
 	`, w, g.AdjCfg, g)
 }
 func (g stringReprStringReprGenerator) GetNodeBuilderGenerator() NodeBuilderGenerator {
-	return stringReprStringReprBuilderGenerator{g.AdjCfg, g.Type}
+	return stringReprStringReprBuilderGenerator(g)
 }
 
 type stringReprStringReprBuilderGenerator struct {

schema/gen/go/genUnionReprKinded.go

@@ -343,11 +343,7 @@ func (g unionKindedReprGenerator) EmitNodePrototypeType(w io.Writer) {
 // --- NodeBuilder and NodeAssembler --->
 
 func (g unionKindedReprGenerator) GetNodeBuilderGenerator() NodeBuilderGenerator {
-	return unionKindedReprBuilderGenerator{
-		g.AdjCfg,
-		g.PkgName,
-		g.Type,
-	}
+	return unionKindedReprBuilderGenerator(g)
 }
 
 type unionKindedReprBuilderGenerator struct {

schema/gen/go/mixins/templateUtil.go

@@ -11,7 +11,7 @@ import (
 func doTemplate(tmplstr string, w io.Writer, data interface{}) {
 	tmpl := template.Must(template.New("").
 		Funcs(template.FuncMap{
-			"title": func(s string) string { return strings.Title(s) },
+			"title": func(s string) string { return strings.Title(s) }, //lint:ignore SA1019 cases.Title doesn't work for this
 		}).
 		Parse(testutil.Dedent(tmplstr)))
 	if err := tmpl.Execute(w, data); err != nil {

schema/gen/go/templateUtil.go

@@ -103,7 +103,7 @@ func doTemplate(tmplstr string, w io.Writer, adjCfg *AdjunctCfg, data interface{
 				}
 			},
 			"add":   func(a, b int) int { return a + b },
-			"title": func(s string) string { return strings.Title(s) },
+			"title": func(s string) string { return strings.Title(s) }, //lint:ignore SA1019 cases.Title doesn't work for this
 		}).
 		Parse(testutil.Dedent(tmplstr)))
 	if err := tmpl.Execute(w, data); err != nil {