feat: switch to zcash-block for decoding

package.json

@@ -37,7 +37,7 @@
     "multicodec": "~0.5.1",
     "multihashes": "~0.4.12",
     "multihashing-async": "~0.8.0",
-    "zcash-bitcore-lib": "~0.13.20-rc3"
+    "zcash-block": "^2.0.0"
   },
   "devDependencies": {
     "aegir": "^20.0.0",

src/resolver.js

@@ -46,7 +46,7 @@ exports.resolve = (binaryBlob, path) => {
 const traverse = function * (node, path) {
   // Traverse only objects and arrays
   if (Buffer.isBuffer(node) || CID.isCID(node) || typeof node === 'string' ||
-      node === null) {
+      node == null) {
     return
   }
   for (const item of Object.keys(node)) {

src/util.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const ZcashBitcoreBlockHeader = require('zcash-bitcore-lib').BlockHeader
+const ZcashBlock = require('zcash-block')
 const CID = require('cids')
 const multicodec = require('multicodec')
 const multihashes = require('multihashes')
@@ -11,13 +11,12 @@ const CODEC = multicodec.ZCASH_BLOCK
 const DEFAULT_HASH_ALG = multicodec.DBL_SHA2_256
 
 /**
- * Serialize internal representation into a binary Zcash block.
+ * Unsupported, this codec cannot serialize Zcash blocks.
  *
  * @param {ZcashBlock} dagNode - Internal representation of a Zcash block
- * @returns {Buffer}
  */
 const serialize = (dagNode) => {
-  return dagNode.toBuffer()
+  throw new Error('Unsupported operation')
 }
 
 /**
@@ -27,42 +26,23 @@ const serialize = (dagNode) => {
  * @returns {ZcashBlock}
  */
 const deserialize = (binaryBlob) => {
-  if (binaryBlob.length !== ZCASH_BLOCK_HEADER_SIZE) {
-    throw new Error(
-      `Zcash block header needs to be ${ZCASH_BLOCK_HEADER_SIZE} bytes`)
-  }
-
-  const deserialized = ZcashBitcoreBlockHeader.fromBuffer(binaryBlob)
+  let deserialized
 
-  const getters = {
-    difficulty: function () {
-      return this.bits
-    },
-    parent: function () {
-      return hashToCid(this.prevHash)
-    },
-    tx: function () {
-      return hashToCid(this.merkleRoot)
-    }
+  if (binaryBlob.length < ZCASH_BLOCK_HEADER_SIZE) {
+    throw new Error(`Zcash block must at least include the ${ZCASH_BLOCK_HEADER_SIZE} header bytes`)
+  } else if (binaryBlob.length === ZCASH_BLOCK_HEADER_SIZE) {
+    deserialized = ZcashBlock.decodeHeaderOnly(binaryBlob)
+  } else {
+    deserialized = ZcashBlock.decode(binaryBlob)
   }
-  Object.entries(getters).forEach(([name, fun]) => {
-    Object.defineProperty(deserialized, name, {
-      enumerable: true,
-      get: fun
-    })
-  })
 
-  const removeEnumberables = [
-    'bits',
-    'merkleRoot',
-    'prevHash',
-    'time'
-  ]
-  removeEnumberables.forEach((field) => {
-    if (field in deserialized) {
-      Object.defineProperty(deserialized, field, { enumerable: false })
-    }
-  })
+  // for go-ipld-zcash compatibility
+  deserialized.timestamp = deserialized.time
+  deserialized.reserved = deserialized.finalsaplingroot
+  deserialized.tx = deserialized.merkleroot
+
+  deserialized.cid = hashToCid(deserialized.hash)
+  deserialized.parent = hashToCid(deserialized.previousblockhash)
 
   return deserialized
 }