Add git resolver #97
Add git resolver #97
Conversation
package.json
Outdated
| @@ -53,6 +53,7 @@ | |||
| "ipld-dag-cbor": "~0.11.1", | |||
| "ipld-dag-pb": "~0.11.0", | |||
| "ipld-eth-star": "^1.4.1", | |||
| "ipld-git": "file:../js-ipld-git", | |||
There was a problem hiding this comment.
woa, this one is new to me. I never saw a file: in a package.json. This is almost like gx-rw
There was a problem hiding this comment.
Once the changes requested in ipld-git are done, let's update this line
There was a problem hiding this comment.
LGTM! Mind adding an example to https://github.com/ipfs/js-ipfs/tree/master/examples/traverse-ipld-graphs ?
Also, would you like to give a demo in the next IPFS all hands?
package.json
Outdated
| @@ -53,6 +53,7 @@ | |||
| "ipld-dag-cbor": "~0.11.1", | |||
| "ipld-dag-pb": "~0.11.0", | |||
| "ipld-eth-star": "^1.4.1", | |||
| "ipld-git": "file:../js-ipld-git", | |||
There was a problem hiding this comment.
Once the changes requested in ipld-git are done, let's update this line
|
@magik6k tests are not happy, wanna check? |
|
Travis fails on node 4 as it doesn't support spread operator (https://travis-ci.org/ipld/js-ipld-resolver/jobs/271251389#L3638) Circle is.. interesting, looks like |
Going to remove the support for it in Master and then you can rebase.
When that happens, just give it a kick :)
|
|
@diasdavid CI looks happier |
| @@ -64,6 +65,10 @@ class IPLDResolver { | |||
| dagCBOR.resolver, | |||
| dagCBOR.util) | |||
|
|
|||
| this.support.add(ipldGit.resolver.multicodec, | |||
| ipldGit.resolver, | |||
| ipldGit.util) | |||
Depends on ipld/js-ipld-git#1