Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain time zone of the lookback parameter #154

Closed
yurishkuro opened this issue Dec 23, 2017 · 7 comments
Closed

Explain time zone of the lookback parameter #154

yurishkuro opened this issue Dec 23, 2017 · 7 comments
Assignees

Comments

@yurishkuro
Copy link
Member

Moved from jaegertracing/jaeger#372

When "Custom Time Range" is specified, it would be good to show in which time zone the entered values are interpreted, either via (?) icon or explicitly "Start Time (TZ=New York [UTC-0500])".

image

@tiffon
Copy link
Member

tiffon commented Dec 23, 2017

Sounds good.

Is UTC-0500 always the relevant time-zone?

Also, as a bit of an aside, I'll add a note to the "Tags" info tooltip noting only exact matches are supported.

@black-adder
Copy link
Contributor

Can you identify the timezone from the browser so that's it's always relevant to the user?

@tiffon
Copy link
Member

tiffon commented Dec 23, 2017

Yes, we can get the timezone the browser is using, but, what timezone does the query-service generally interpret the date/time as?

@yurishkuro
Copy link
Member Author

query-service doesn't interpret it, because UI is passing a Unix timestamp, which is relative to an absolute point in time, midnight of Jan 1 1970 in UTC time.

@tiffon tiffon added the next label Dec 24, 2017
@tiffon
Copy link
Member

tiffon commented Dec 24, 2017

Got it. Yes, I can add a note stating the time-values being entered are in local timezone of the browser and will be converted to UTC when sent to the server.

@yurishkuro
Copy link
Member Author

"local" is good, but actually showing what it is is even better.

@tiffon
Copy link
Member

tiffon commented Dec 24, 2017

@yurishkuro I agree, 100%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants