Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support trace view as a flame graph #525

Closed
hehe717 opened this issue Feb 19, 2020 · 9 comments · Fixed by #976
Closed

Support trace view as a flame graph #525

hehe717 opened this issue Feb 19, 2020 · 9 comments · Fixed by #976

Comments

@hehe717
Copy link

hehe717 commented Feb 19, 2020

I am implementing jaeger, it really looks nice.
But I got a problem.
I want to collect spans on one line in tracing view, but I cannot find way.

[As-IS]
image

[To-Be]
image

Maybe I can't find the doc... could you help ?

@yurishkuro
Copy link
Member

The flame-graph kind of view is not supported in Jaeger.

@yurishkuro yurishkuro changed the title Is there any way to collect spans in one line? Support trace view as a flame graph Feb 19, 2020
@yurishkuro yurishkuro transferred this issue from jaegertracing/jaeger Feb 19, 2020
@yurishkuro
Copy link
Member

The challenge with this type of view is that sibling spans are not guaranteed to not overlap, so how should they be displayed in that case?

|----------------parent---------------|
    |---child1---|
                |---child2---|

@hehe717
Copy link
Author

hehe717 commented Feb 19, 2020

Yes.. I didn't think that part.

Datadog's tracing view can be hint for this problem. (they have implemented flame graph with open tracing )
https://docs.datadoghq.com/tracing/visualization/trace/?tab=spantags

And, Overlapped graph can be great help to developer if developer set kinds of order spans by operationName

image

@yurishkuro
Copy link
Member

DD docs don't explain how the they deal with overlapping siblings, unless I missed it

@hehe717
Copy link
Author

hehe717 commented Feb 20, 2020

Right , closed this issue because of the challenge of sibling spans does not guarantee to not overlap

@n1ckdm
Copy link

n1ckdm commented Nov 13, 2021

I think this issue should be reopened. Flamegraph support for jaeger would be really useful for some of the systems I'm working with.

This tool takes a JSON dump from jaeger and converts it to be read by FlameGraph:

https://github.com/symbiont-io/jaeger-flamegraph

Might be some clues there for how to handle the overlapping siblings?

I'd be interested in working on a PR for this if there's appetite for it?

@ColinBradley
Copy link

FWIW, I'd really like this feature too.
Datadog and Raygun both have flame graph esk views and they are incredibly helpful.

The sibling overlapping issue is a small edge case you can handle by just putting them on different rows. It's fine - parallel work is just messy.

Basically the entire logic is that spans should go on a new row if there is no room on a preceding row and never going higher than a parent. I've made and used a basic viewer like this in the past and it worked great.

@h1z3y3
Copy link

h1z3y3 commented Apr 25, 2022

+1

@novohool
Copy link

+2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants