From 2e1b869509a14e32548eb803c4c5cf8c8073dc64 Mon Sep 17 00:00:00 2001 From: Pavol Loffay Date: Tue, 22 Sep 2020 12:23:09 +0200 Subject: [PATCH] Fix ES OTEL status code (#2501) Signed-off-by: Pavol Loffay --- .../elasticsearchexporter/esmodeltranslator/modeltranslator.go | 3 +-- .../esmodeltranslator/modeltranslator_test.go | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/cmd/opentelemetry/app/exporter/elasticsearchexporter/esmodeltranslator/modeltranslator.go b/cmd/opentelemetry/app/exporter/elasticsearchexporter/esmodeltranslator/modeltranslator.go index c6c5b4a7c32..06110e5ecde 100644 --- a/cmd/opentelemetry/app/exporter/elasticsearchexporter/esmodeltranslator/modeltranslator.go +++ b/cmd/opentelemetry/app/exporter/elasticsearchexporter/esmodeltranslator/modeltranslator.go @@ -367,8 +367,7 @@ func getTagFromSpanKind(spanKind pdata.SpanKind) (dbmodel.KeyValue, bool) { func getTagFromStatusCode(statusCode pdata.StatusCode) (dbmodel.KeyValue, bool) { return dbmodel.KeyValue{ - Key: tracetranslator.TagStatusCode, - // TODO is this ok? + Key: tracetranslator.TagStatusCode, Value: statusCode.String(), Type: dbmodel.StringType, }, true diff --git a/cmd/opentelemetry/app/exporter/elasticsearchexporter/esmodeltranslator/modeltranslator_test.go b/cmd/opentelemetry/app/exporter/elasticsearchexporter/esmodeltranslator/modeltranslator_test.go index d7cd5f0ae77..d2405d95eab 100644 --- a/cmd/opentelemetry/app/exporter/elasticsearchexporter/esmodeltranslator/modeltranslator_test.go +++ b/cmd/opentelemetry/app/exporter/elasticsearchexporter/esmodeltranslator/modeltranslator_test.go @@ -151,7 +151,7 @@ func TestConvertSpan(t *testing.T) { StartTimeMillis: 1, Tags: []dbmodel.KeyValue{ {Key: "span.kind", Type: dbmodel.StringType, Value: "client"}, - {Key: "status.code", Type: dbmodel.StringType, Value: "Cancelled"}, + {Key: "status.code", Type: dbmodel.StringType, Value: "STATUS_CODE_CANCELLED"}, {Key: "error", Type: dbmodel.BoolType, Value: "true"}, {Key: "status.message", Type: dbmodel.StringType, Value: "messagetext"}, {Key: "foo", Type: dbmodel.BoolType, Value: "true"},