Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TraceID to Logs in HotRod Example Application #2310

Closed
ghostsquad opened this issue Jun 25, 2020 · 2 comments · Fixed by #2384
Closed

Add TraceID to Logs in HotRod Example Application #2310

ghostsquad opened this issue Jun 25, 2020 · 2 comments · Fixed by #2384
Assignees
@ghostsquad
Labels
help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@ghostsquad
Copy link

This is a request to add the TraceID to logs for the HotRod application. This would allow for some cool demos, especially with Grafana 7.0 and it's support for unification of metrics, logs and jaeger tracing.
@ghost ghost added the needs-triage label Jun 25, 2020
@pavolloffay pavolloffay added help wanted Features that maintainers are willing to accept but do not have cycles to implement and removed needs-triage labels Jun 26, 2020
@pavolloffay
Copy link
Member

Would you like to submit a patch for it?

@ghostsquad
Copy link
Author

Ya. This would be a good exercise for me.

@joe-elliott joe-elliott mentioned this issue Aug 12, 2020
Merged
@fktkrt fktkrt mentioned this issue Aug 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghostsquad ghostsquad

Labels
help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added span and trace id to hotrod logs joe-elliott/jaeger
2 participants
@ghostsquad @pavolloffay