Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish implementing trace anonymizer #2556

Closed
yurishkuro opened this issue Oct 13, 2020 · 5 comments · Fixed by #2585 or #2629
Closed

Finish implementing trace anonymizer #2556

yurishkuro opened this issue Oct 13, 2020 · 5 comments · Fixed by #2585 or #2629
Assignees
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

Requirement - what kind of business use case are you trying to solve?

Allow people to safely export production traces into GitHub tickets (as a way of reproducing problems, especially with the UI) without exposing sensitive information.

Problem - what in Jaeger blocks you from solving the requirement?

The anonymizer is partially implemented.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Finish the implementation as follows

  • extend the Anonymizer type with these additional parameters
    • hashStandardTags - when true, the allowsTags are also hashed, when false they are preserved as is
    • hashCustomTags - when true, all other tags are hashed, when false they are dropped (current behavior)
    • hashLogs - when true, logs are hashed, when false they are dropped (current behavior)
    • hashProcess - when true, process tags are hashed, when false they are dropped (current behavior)
  • implement main program
    • add option to specify query service gRPC address to load the trace
    • add option to specify trace ID to load from gRPC query service
    • add option to specify output directory to save the file
    • add options for Anonymizer configuration parameters
    • when saving anonymized trace to a file, it first must be converted to the UI model (see writer package)
      • validation: the trace should be loadable by Jaeger UI (Load JSON tab in the Search panel)

cc @jpkrohling

@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement outreachy good first issue Good for beginners labels Oct 13, 2020
@Ashmita152
Copy link
Contributor

Hi @yurishkuro @jpkrohling may I pick and try solving this issue as two PRs for the two parts.

@jpkrohling
Copy link
Contributor

It's yours!

@Ashmita152
Copy link
Contributor

Hi @yurishkuro

This PR implements only the first part of the issue, second part (main program) is still remaining, which I am planning to pick next. Sorry for creating the confusion.

@yurishkuro yurishkuro reopened this Oct 29, 2020
@yurishkuro
Copy link
Member Author

Yes, I know - github auto-closed the issue because the PR had a magic clause "fixes ####".

@Ashmita152
Copy link
Contributor

Sorry my bad, I shouldn't have added fixes ## thing in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
3 participants