Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate away from curator #3179

Closed
pavolloffay opened this issue Aug 4, 2021 · 2 comments
Closed

Migrate away from curator #3179

pavolloffay opened this issue Aug 4, 2021 · 2 comments
Labels
storage/elasticsearch

Comments

@pavolloffay
Copy link
Member

Library elasticsearch-python that is used by curator added a check to verify that ES is elastic.co product https://github.com/elastic/elasticsearch-py/releases/tag/v7.14.0.

So now our index cleaner and rollover scritps fail to run with old ES (5.x and even old -oss versions). Here is failed build https://github.com/jaegertracing/jaeger/pull/3178/checks?check_run_id=3240658056#step:6:835

I propose to migrate the python scripts to golang and as a quick fix we can pin the elasticserch-python to an older version without the check.
This was referenced Aug 4, 2021
Merged
Merged
@jpkrohling
Copy link
Contributor

Yes, please!

This was referenced Aug 6, 2021
Merged
Merged
This was referenced Sep 8, 2021
Merged
Merged
@pavolloffay
Copy link
Member Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
storage/elasticsearch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpkrohling @pavolloffay