Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin dependencies that do not use semver to specific commits #887

Closed
yurishkuro opened this issue Jun 26, 2018 · 3 comments
Closed

Pin dependencies that do not use semver to specific commits #887

yurishkuro opened this issue Jun 26, 2018 · 3 comments
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

As decided on the last call https://docs.google.com/document/d/1ZuBAwTJvQN7xkWVvEFXj5WU9_JmS5TPiNbxCJSvPqX0/edit#heading=h.xdsshpxv2gpd

@jpkrohling jpkrohling added enhancement help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Jun 27, 2018
@burmanm
Copy link
Contributor

burmanm commented Jul 10, 2018

At least gogo/protobuf should be parked, otherwise tests will break. At least on my machine, version: 30cf7ac33676b5786e78c746683f0d4cd64fa75b works, but with glide update one gets: version: 100ba4e885062801d56799d78530b73b178a78f3 and that one breaks with error message invalid character 'A' looking for beginning of value from integration_test.go (storage-integration-test target)

Although that could be a sign of something else as well. Just reporting it here in case someone else runs to that issue (I had real fun finding it).

@bhavin192
Copy link

As we have switched to dep in #1240. I can see only one dependency which says branch = master which is github.com/crossdock/crossdock-go. I think this issue can be closed.

@yurishkuro
Copy link
Member Author

@bhavin192 thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Development

No branches or pull requests

4 participants